Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350192 - [MS Toolchain] Cannot create C projects for MS SDK (C++ works)
Summary: [MS Toolchain] Cannot create C projects for MS SDK (C++ works)
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build (show other bugs)
Version: 8.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 8.0.1   Edit
Assignee: Marc-André Laperle CLA
QA Contact: Andrew Gvozdev CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-23 17:21 EDT by Joan Touzet CLA
Modified: 2011-06-29 13:37 EDT (History)
3 users (show)

See Also:


Attachments
MS Toolchain C patch (19.27 KB, patch)
2011-06-28 13:03 EDT, Marc-André Laperle CLA
malaperle: iplog-
Details | Diff
MS Toolchain C patch, updated (11.54 KB, patch)
2011-06-29 01:05 EDT, Marc-André Laperle CLA
malaperle: iplog-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joan Touzet CLA 2011-06-23 17:21:05 EDT
Build Identifier: 20110615-0604

There are no entries to create a MS SDK C project in the project wizard. Similarly, a wizard-created C++ project will ignore all .c files inside of it, proclaiming nothing to build.

Is there a workaround to creating MS SDK-targeted C projects other than renaming all .c files to .cpp inside a wizard-created C++ project?

Reproducible: Always
Comment 1 Marc-André Laperle CLA 2011-06-28 13:03:34 EDT
Created attachment 198757 [details]
MS Toolchain C patch

Similarly to the GCC toolchain, I split the C/C++ Compiler tool into C Compiler and C++ Compiler and added the C input type to C Compiler. That way paths, symbols and options can be set per language like the GCC toolchain. The options inside C++ Compiler retain the same ids which means projects will upgrade correctly (I tested it). Also added template associations to allow creating hello world projects with the toolchain.
Comment 2 Marc-André Laperle CLA 2011-06-28 13:09:50 EDT
Andrew, does this solution sound reasonable to you?
Comment 3 Andrew Gvozdev CLA 2011-06-28 15:04:03 EDT
(In reply to comment #2)
> Andrew, does this solution sound reasonable to you?
This is certainly the way to go. And if you have much similarities between MS C and C++ tools I suggest to consider creating "base" MS C compiler tool and extend them from that "superClass", that would make maintenance easier.
Comment 4 Marc-André Laperle CLA 2011-06-29 01:05:05 EDT
Created attachment 198785 [details]
MS Toolchain C patch, updated

Thanks, I put the common things in an abstract tool. I tried that before but it didn't work properly, I think I didn't have the abstract tool at the top level. I'd like to commit that to 8.0 as well as master but it adds some new strings. I guess having untranslated strings is better than waiting a full year before being able to compile C.
Comment 5 Andrew Gvozdev CLA 2011-06-29 07:43:13 EDT
(In reply to comment #4)
> Created attachment 198785 [details]
> I'd like to commit that to 8.0 as well as master but it adds some new strings. I
> guess having untranslated strings is better than waiting a full year before
> being able to compile C.
What's a problem with that, why can't you externalize the strings in 8.0?
Comment 6 Marc-André Laperle CLA 2011-06-29 13:05:53 EDT
(In reply to comment #5)
> What's a problem with that, why can't you externalize the strings in 8.0?

I was under the impression that Babel couldn't have translations specific to service releases but I see there is 5.0.1.
Comment 7 Marc-André Laperle CLA 2011-06-29 13:37:15 EDT
Fixed in 8.0 and master.