Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 350090 - [Compatibility] No icon for view tool item
Summary: [Compatibility] No icon for view tool item
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M1   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 350080
  Show dependency tree
 
Reported: 2011-06-22 14:44 EDT by Remy Suen CLA
Modified: 2011-06-30 14:07 EDT (History)
1 user (show)

See Also:

Attachments
Screenshot depicting the behaviour in question. (10.35 KB, image/png)
2011-06-22 14:44 EDT, Remy Suen CLA 		no flags Details
MenuAdditionCacheEntry patch v1 (1.81 KB, patch)
2011-06-30 14:06 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-06-22 14:44:11 EDT 
Created attachment 198428 [details]
Screenshot depicting the behaviour in question.

It seems like drop down tool items for views don't get icons for whatever reasons.
Comment 1 Remy Suen CLA 2011-06-30 09:08:13 EDT 
Might be related to bug 350799 since they're both dropdowns. Though in this case the image doesn't even appear.
Comment 2 Remy Suen CLA 2011-06-30 14:06:29 EDT 
Created attachment 198924 [details]
MenuAdditionCacheEntry patch v1

We need to query the command image service with the command id for an image if an icon has not been specified.
Comment 3 Remy Suen CLA 2011-06-30 14:07:37 EDT 
(In reply to comment #2)
> Created attachment 198924 [details]
> MenuAdditionCacheEntry patch v1

Patch released to CVS HEAD.