Community
Participate
Working Groups
The available IU page has a checkbox viewer to show the available IUs that could be belonged to more than one category. If using org.eclipse.jface.viewers.CheckboxTreeViewer.setSubtreeChecked(Object, boolean) to check the tree items, some duplicated items couldn't be checked. Because the implementation of CheckboxTreeViewer.setSubtreeChecked finds the tree item via the content's equals() method.
Created attachment 198379 [details] proposed fix
I'm not familiar with that code, could you please describe an example of where this will be happening and the sort of pb that could cause to the user? I may have misunderstood. Thx.
(In reply to comment #2) > I'm not familiar with that code, could you please describe an example of where > this will be happening and the sort of pb that could cause to the user? I may > have misunderstood. Thx. Use the Indigo repository(http://download.eclipse.org/releases/indigo) in the install wizard, you can find 'PHP Development Tool' under three different categories(General purpose, Language and Web development tool). The viewer is a checkbox tree viewer, clients might want to programmaticsly check the entire category such as 'Web development tool'. The clients probably calls the API org.eclipse.jface.viewers.CheckboxTreeViewer.setSubtreeChecked(Object, boolean) that find the children tree items via comparing to the data objects(call obj1.equals(obj2)). Current implementation of AvailableIUElement.equals has flaw, the same name item(PHP Development Tool) under other categories might be checked.
Thx for the explanation. Go ahead and release the change. If you want to have this be backported to Indigo, please clone this bug and assign it 3.7.1.
fixed in HEAD
Should you want to release it in 3.7.x please clone this bug for easier traceability
(In reply to comment #6) > Should you want to release it in 3.7.x please clone this bug for easier > traceability I see. But there is no strong reason to release it in 3.7.x. :)
Then I'm happy to not fix it for 3.7.x :)
