Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349994 - [LML] Active/Inactive Job View Contents 'Squished'
Summary: [LML] Active/Inactive Job View Contents 'Squished'
Status: CLOSED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RM (show other bugs)
Version: 7.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Claudia Knobloch CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 381451
Blocks:
  Show dependency tree
 
Reported: 2011-06-21 19:17 EDT by Wyatt Spear CLA
Modified: 2014-05-30 15:34 EDT (History)
5 users (show)

See Also:


Attachments
Screen shot showing table rendering error (66.40 KB, image/png)
2011-06-21 19:31 EDT, Wyatt Spear CLA
no flags Details
Program which should simulate the problem (23.87 KB, application/x-java-archive)
2011-07-26 08:25 EDT, Claudia Knobloch CLA
no flags Details
Workaround for the squished rows issue. (1.93 KB, patch)
2012-10-24 09:02 EDT, Carsten Karbach CLA
no flags Details | Diff
Workaround for the squished rows issue. Added comment referencing this bug. The workaround is only called for GTK environments. (2.12 KB, patch)
2012-11-12 10:41 EST, Carsten Karbach CLA
no flags Details | Diff
Calls the function for fixing the row heights also when filtering is active. (1.75 KB, patch)
2013-01-31 03:03 EST, Carsten Karbach CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wyatt Spear CLA 2011-06-21 19:17:22 EDT
After creating an LML_JAXB resource manager for PBS start the RM and go to the System Monitoring perspective.  If there are other jobs detected by the RM initially they will display correctly in the Active/Inactive jobs views.  However as soon as any of the content updates or their frames are re-sized the table rows will become stacked too tightly, making reading the output difficult or impossible, as shown in the attached screenshot.  Stopping and restarting the rm will briefly restore the layout but playing with the UI does not seem to work.  This is observed on 64 bit Ubuntu 10.10 using 64 bit Sun Java 1.6.0_24 and Eclipse Indigo rc 5.
Comment 1 Wyatt Spear CLA 2011-06-21 19:31:18 EDT
Created attachment 198365 [details]
Screen shot showing table rendering error
Comment 2 Claudia Knobloch CLA 2011-06-22 08:45:28 EDT
I checked the problem under Windows 7 and it does not occur. I also checked the problem under SuSe 11.3 and SuSe 11.4. The re-sizing problem does not occur, but the update one (although the rows are not so tightly stacked) and maybe a similar one.

My problem is if I select a row the rows will become stacked too. The rows are still readable.

In my case it only effects the Active Jobs Table (but I did not have a job started by myself in that table). So maybe we still have a problem with the build-in functionality from LLview.
Comment 3 Greg Watson CLA 2011-07-21 12:14:04 EDT
We had a few people at the training today who had the same issue. It turns out they were all running Ubuntu. Other Linux users didn't appear to have the problem, so I believe this is specific to Ubuntu.
Comment 4 Claudia Knobloch CLA 2011-07-21 12:27:03 EDT
Since I am using another Linux distribution than Ubuntu, I think it is a Linux specific problem.
Comment 5 Greg Watson CLA 2011-07-21 12:45:10 EDT
It only seems to affect certain linux installations. It's possible it's a GTK or Java version issue. I think we need to collect more information about the machines where it occurs.
Comment 6 Claudia Knobloch CLA 2011-07-26 08:25:24 EDT
Created attachment 200352 [details]
Program which should simulate the problem

The current state of the program Greg asked me to implement.
Comment 7 Claudia Knobloch CLA 2011-07-26 08:27:12 EDT
Recently I discovered the problem also effects the table with the inactive jobs. Since all activities between the table with the inactive jobs and the nodedisplay are disabled, I do not think anymore that this problem is connected to the LLview functionality (mentioned in comment 2).

During the search of the cause of this behavior I recognized that this problem occurs when the input is refreshed. This can happen for example after a sorting of the data, after starting a job or an update of the system. After I mentioned the discovery in one of the last calls with Greg, he asked me to implement a program simulating the problem so that we can ask SWT expert to examine the code. 

I just have problems to reproduce the behavior. I tried different scenarios. First I implemented the table view with a similar kind of data in the background (in package tablebehavior.model). To implement the view I copied the code from TableView of the plugin org.eclipse.ptp.rm.lml.ui and customized the code. Finally I added a perspective and still I can not reproduce the problem.

Has anyone further ideas what can cause the behavior?
Comment 8 Greg Watson CLA 2012-04-26 09:03:25 EDT
I tried the sample on Mac and Ubuntu Linux and I don't see the problem either. Can you try removing the icon in the first column to see if this is causing the problem?
Comment 9 Greg Watson CLA 2012-05-01 15:38:30 EDT
I tried again on Ubuntu, including clicking on the headers to sort the table. However, I don't see the squishing.

Wyatt, are you still seeing this problem?
Comment 10 Wyatt Spear CLA 2012-06-01 18:52:57 EDT
Yes, I'm seeing it right now on the very latest pull from Head.  (Sorry for the delayed reply. Good news: I *should* start getting the e-mails from Eclipse bugzilla starting now)
Comment 11 Greg Watson CLA 2012-06-01 19:53:42 EDT
You're on Ubuntu, right? I've opened a bug against platform to see if they can help.
Comment 12 Carsten Karbach CLA 2012-10-24 09:02:56 EDT
Created attachment 222723 [details]
Workaround for the squished rows issue.

By trying to find the reason for the rows getting squished, I came across a workaround for this problem. If the rows are squished, the table corrects the rows' heights as soon as you disable/hide a column. Currently columns are hidden by setting their widths to zero. It is even sufficient to slightly change the width of a column in order to bring the rows to a normal size.

As a result, this patch introduces a function, which decreases the width of the last column by one pixel. Afterwards, the width is set to its original value. This adjustment is not visible in the UI, but makes sure that the row heights are set correctly. This function is called every time the table's content changes.

For my openSUSE 12.1 system this patch avoids the squishing of the table rows. Could someone with an Ubuntu system please apply this patch and check if the rows are still squished?

Should I commit this workaround or does anyone have a suggestion for avoiding to decrease and increase the width of a column in order to force a table refresh?
Comment 13 Greg Watson CLA 2012-10-26 10:30:23 EDT
I think it's ok to have a workaround to fix a bug like this. However, since this is only a linux/gtk problem, I would suggest checking SWT.getPlatform() is "gtk" or org.eclipse.jfact.util.Util.isGtk() is true before calling the code. Also, please add a comment in the code referencing this bug.
Comment 14 Carsten Karbach CLA 2012-11-12 10:41:33 EST
Created attachment 223458 [details]
Workaround for the squished rows issue. Added comment referencing this bug. The workaround is only called for GTK environments.

This patch has been committed to ptp_6_0 and master.
Comment 15 Carsten Karbach CLA 2013-01-31 03:03:08 EST
Created attachment 226364 [details]
Calls the function for fixing the row heights also when filtering is active.

The rows still get squished, if any filtering operation is active.
The reason for that is, that the function, which fixes the row heights, is only called in the default case without filtering.

This patch just adds a call to the corresponding function into the table update function, which is called when filtering is active.
Comment 16 Carsten Karbach CLA 2013-01-31 03:53:45 EST
This has been fixed in ptp_6_0 and master
Comment 17 Greg Watson CLA 2014-05-30 15:34:31 EDT
Closing as fixed.