Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349976 - Git status commands need user readable names and tooltips
Summary: Git status commands need user readable names and tooltips
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.3 RC2   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 14:30 EDT by John Arthorne CLA
Modified: 2011-10-11 10:37 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-06-21 14:30:01 EDT 
Commands have a name and an optional tooltip. However, in the tooltip hover we are always showing the command name rather than the tooltip attribute. The tooltip attribute doesn't ever seem to be used.

This shows up in the "Stage all" and "Unstage all" commands, which look like this:

			var unstageAllCommand = new mCommands.Command({
				name: "unstageAll",
				tooltip: "Unstage all",

In the UI, the tooltip hover shows the goofy "unstageAll" rather than the actual tooltip, "Unstage all".
Comment 1 Susan McCourt CLA 2011-09-20 12:10:15 EDT 
Several things going on here.

In bug 358162, we are addressing that we have never used the tooltip anywhere in the UI.  We are going to set the tooltip in the command anchor tag that contains text or image.  

However, for image commands, we also set the tooltip for the image to the command name.  This is so that we can explain the icons.  So the name will show in the icon case, the tooltip will show in the text case.

Since general use of tooltip is covered in bug 358162, let's target this bug to the stage all and unstage all commands, which need proper names.  The name should be set to "Unstage All" and a real tooltip defined.  Such as:

 var unstageAllCommand = new mCommands.Command({
                name: "Unstage All",
                tooltip: "Unstage all staged files",

(One could argue that the tooltip is not needed/doesn't add much).
Comment 2 Susan McCourt CLA 2011-09-20 12:18:27 EDT 
Libing, could you check all your git status commands and ensure that:

- the "name" property is set to a user readable name.  This name will appear when the command is contributed as a text link, and will also appear as the hover when the icon is used.
- the "tooltip" property is set to a short descriptive tooltip.  This appears as the hover when the name is already shown in a text link.
Comment 3 Simon Kaegi CLA 2011-10-07 16:24:53 EDT 
Is this done?
Comment 4 libing wang CLA 2011-10-11 10:37:41 EDT 
yes. Fixed with fde48456846a7cacb6844b429453bcd4835a3743.