Community
Participate
Working Groups
Git Init should be a task. We also need to update tests when it is done.
Piotrek, when you are looking at this bug and tests for Git Init, please add tests for missing cases like Bug 349868.
(In reply to comment #0) > Git Init should be a task. What's the rationale for that? Init is not supposed to be a long running operation.
I think we already talked about that. Timeouts can happen not only for operations on remote Git servers. From time to time I can see timeouts during log operations and it may happen for status and init. The point is to use the task framework for all important operations to improve the end-user experience in case of such timeouts. There is also a place for an improvement in our task framework. Right now, it always returns the task location and we need to check the task, even if the task was finished quickly. In such a case we could just return the result immediately instead of returning the task location. Then in most cases for operations like Git Init, there would be no task locations flying around between the client and server. Moreover we could decide whether we want to start an operation as a task or not, see Bug 350026.
Fix. client: https://github.com/pjanik/orion.client/tree/bug349952 server: https://github.com/pjanik/orion.server/tree/bug349952 I've also added a test, which checks if the configuration (user.name and user.email) after git init operation is valid (Bug 349868).
Fixed with da9330d6fff0770fef0bfb1554b85c4f963ab7a6 and a1cccf0254e0fec09366f5805ea89b25f382b939.
