Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349867 - [UI] DnD needs polish
Summary: [UI] DnD needs polish
Status: CLOSED DUPLICATE of bug 367920
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: 4.2 RC1   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 375194 (view as bug list)
Depends on: 367920
Blocks:
  Show dependency tree
 
Reported: 2011-06-20 15:32 EDT by Eric Moffatt CLA
Modified: 2012-05-21 15:30 EDT (History)
5 users (show)

See Also:

Attachments
Patch for item 3, move the logic for takign the whole stack into the SplitDropAgent (5.03 KB, patch)
2011-06-20 15:36 EDT, Eric Moffatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2011-06-20 15:32:57 EDT 
There are still some remaining polish issues with the DnD:

1) The drop agents don't relinquish control when you drag over a DW (because they are using the cursor position only rather than the Control the cursor is over.

2) The feedback should be reversed so that the feedback we currently use for an 'outer' dock should be the regular split affordance and we use something else for the outer dock behavior.

3) The 'drag single visible element == drag whole stack' should only take place when you 'split' drop (i.e. dropping the view into an existing stack should *not* bring over the placeholders).

4) Sometimes we seem to lose the 'drop', I release the mouse button but still end up in the DnD loop.
Comment 1 Eric Moffatt CLA 2011-06-20 15:36:16 EDT 
Created attachment 198283 [details]
Patch for item 3, move the logic for takign the whole stack into the SplitDropAgent
Comment 2 Eric Moffatt CLA 2011-09-15 12:52:55 EDT 
M2 is done...
Comment 3 Eric Moffatt CLA 2011-12-09 11:30:08 EST 
Moving to M5.
Comment 4 Eric Moffatt CLA 2012-04-10 15:30:09 EDT 
*** Bug 375194 has been marked as a duplicate of this bug. ***
Comment 5 Eric Moffatt CLA 2012-04-25 14:55:48 EDT 
commit e40e48271284969e479f3318324e3c5abe57b8f6

This commit moves over to using the SWT 'MOD1' keystate rather than 'CTRL'. This means the modifier is 'Ctrl' on most systems but 'Command' on the Mac.

It also does a somewhat better job of handling the 'inner' drop case (dragging an element into the shared area edge.

There is still an issue in that the default when simply dragging a view into the shared area (not at an edge) still defaults to moving the view / stack into the shared area (which is what we're trying to avoid).
Comment 6 Eric Moffatt CLA 2012-04-27 15:53:56 EDT 
commit dfc69964ab6338aed1f02bfabf13a1aaaf00da62

Ooops! the previous commit left the 'outer drop' (at the edge of the perspective) move the view outside the perspective again...
Comment 7 Eric Moffatt CLA 2012-05-07 10:07:18 EDT 

*** This bug has been marked as a duplicate of bug 371785 ***
Comment 8 Alexander Wessel CLA 2012-05-21 10:28:45 EDT 
(In reply to comment #7)
> 
> *** This bug has been marked as a duplicate of bug 371785 ***

Eric, are you sure the duplicate is correct? They seem pretty unrelated to me... Did you mean Bug 367920 instead?
Comment 9 Eric Moffatt CLA 2012-05-21 15:28:55 EDT 
Re-opening as per Alex's comment
Comment 10 Eric Moffatt CLA 2012-05-21 15:29:21 EDT 

*** This bug has been marked as a duplicate of bug 367920 ***
Comment 11 Eric Moffatt CLA 2012-05-21 15:30:07 EDT 
Thanks Alex !