Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349860 - Adding patch for performance framework to accommodate a few bugs due to change in releng
Summary: Adding patch for performance framework to accommodate a few bugs due to chang...
Status: RESOLVED FIXED
Alias: None
Product: WTP Releng
Classification: WebTools
Component: releng (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: David Williams CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-20 14:37 EDT by Matthew Martire CLA
Modified: 2011-06-21 10:57 EDT (History)
0 users

See Also:

Attachments
patch for properties files (4.19 KB, patch)
2011-06-20 14:40 EDT, Matthew Martire CLA 		no flags Details | Diff
patch for releng.wtpbuilder project (4.03 KB, patch)
2011-06-20 14:55 EDT, Matthew Martire CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Martire CLA 2011-06-20 14:37:27 EDT 
Build Identifier: 

This patch updates the location of the tobeInstalled.properties file. It also takes care of some issues with the dependecies.properties file (this file has been changed from 3.2.3 to 3.2.4). 

Reproducible: Always
Comment 1 Matthew Martire CLA 2011-06-20 14:40:31 EDT 
Created attachment 198278 [details]
patch for properties files
Comment 2 Matthew Martire CLA 2011-06-20 14:40:59 EDT 
Please commit these changes to the HEAD stream as well as the 3.2.5 stream
Comment 3 David Williams CLA 2011-06-20 14:46:41 EDT 
This patch doesn't apply to what I have. 

I think its because you are working with some "project" named webtools.releng, but, in fact, releng.wtpbuilder is meant to be checked out as its own top level project or module. 

Is there some reason you do not do that? Seems we've encountered this before?
Comment 4 Matthew Martire CLA 2011-06-20 14:55:56 EDT 
Created attachment 198280 [details]
patch for releng.wtpbuilder project

Sorry, I guess I keep forgetting that part. Added the correct patch :)
Comment 5 David Williams CLA 2011-06-20 17:40:12 EDT 
I've applied, since doesn't effect normal build paths. 
 
But, looking this again, what is perfbuild.xml file and why is it in 'wtp.tests' directory? 

I did a text search, and could not find where this was "called" from. Any pointers? Any thoughts on moving it? Could it go to "standalone" tests as well? Just to help emphasize it doesn't effect normal build or unit tests?
Comment 6 Matthew Martire CLA 2011-06-21 10:57:48 EDT 
perfbuild.xml gets called in standalovePerfTest.xml in the 'run' target. I'm not sure if it would be ok to move that file out, I dont see any need to.