Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349784 - Javadoc warning in official build
Summary: Javadoc warning in official build
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.8 M1   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 348095
Blocks:
  Show dependency tree
 
Reported: 2011-06-20 03:41 EDT by Dani Megert CLA
Modified: 2011-07-06 03:29 EDT (History)
3 users (show)

See Also:


Attachments
patch (671 bytes, patch)
2011-06-22 10:55 EDT, Andrew Niefer CLA
no flags Details | Diff
updated patch (670 bytes, patch)
2011-06-23 11:23 EDT, Andrew Niefer CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-06-20 03:41:20 EDT
N20110618-2000.

Javadoc warning in official build:

../org.eclipse.pde.build/src/org/eclipse/pde/internal/build/IPDEBuildConstants.java:13: package org.eclipse.pde.internal.publishing does not exist
import org.eclipse.pde.internal.publishing.Constants;
                                          ^
1 warning
Comment 1 Andrew Niefer CLA 2011-06-22 10:55:22 EDT
Created attachment 198411 [details]
patch

Does this look right? The package in question comes from p2.
Comment 2 Dani Megert CLA 2011-06-23 08:55:24 EDT
The publisher is already on the classpath:
;../org.eclipse.equinox.p2.publisher.eclipse/pdepublishing.jar

so the question is why org.eclipse.equinox.p2.publisher.eclipse no longer delivers the code in the pdepublishing.jar but instead exploded? This is the only bundle that does this.

Your patch *might* work but it should also remove the existing entry mentioned above.
Comment 3 Andrew Niefer CLA 2011-06-23 11:05:57 EDT
Ah, didn't notice the pdepublishing.jar there.  The problem here is related to bug 348095.
Comment 4 Andrew Niefer CLA 2011-06-23 11:23:39 EDT
Created attachment 198475 [details]
updated patch
Comment 5 Andrew Niefer CLA 2011-06-23 11:26:53 EDT
I've released the new patch and the fix for 348095 to put the publishing.eclipse bundle in the normal shape.
Comment 6 Dani Megert CLA 2011-07-04 09:22:23 EDT
Verified in N20110701-2000.
Comment 7 Dani Megert CLA 2011-07-06 03:19:44 EDT
The bug reappears in I20110705-0800. It looks like PDE did not do a correct build input. I've released pde.doc now.