Community
Participate
Working Groups
When the staging view is not active, but a repository is selected in the package explorer, activating the view does not display the staged and unstaged content. It is necessary to click in the package explorer with the view visible for the repository selection to be visible.
merged as 3e25690c8687568f321a2f04e4fd6a42cfe3f78b
It seems this bug isn't fixed. I upgraded from Ubuntu 15.10 to 16.04, and I've updated eclipse as well. Current version: Version: Mars.2 Release (4.5.2) Build id: 20160218-0600 ..and I get exactly the same behavior as Robert Munteanu described.
(In reply to Torbjörn Stabo from comment #2) > It seems this bug isn't fixed. I upgraded from Ubuntu 15.10 to 16.04, and > I've updated eclipse as well. Current version: > > Version: Mars.2 Release (4.5.2) > Build id: 20160218-0600 > > ..and I get exactly the same behavior as Robert Munteanu described. ..well, that was a too short one. What I meant to say was that before upgrading eclipse and Ubuntu 15.10->16.04 I didn't have this problem.
(In reply to Torbjörn Stabo from comment #3) > (In reply to Torbjörn Stabo from comment #2) > > It seems this bug isn't fixed. I upgraded from Ubuntu 15.10 to 16.04, and > > I've updated eclipse as well. Current version: > > > > Version: Mars.2 Release (4.5.2) > > Build id: 20160218-0600 > > > > ..and I get exactly the same behavior as Robert Munteanu described. > > ..well, that was a too short one. What I meant to say was that before > upgrading eclipse and Ubuntu 15.10->16.04 I didn't have this problem. I can also confirm this. I have just upgraded from Ubuntu 15.10 -> 16.04 and I am experiencing the same issue. Version: Mars.2 Release (4.5.2) Build id: 20160218-0600 Egit: 4.6.0.201612231935-r
Looks like a regression introduced in the fixes for bug 460243.
New Gerrit change created: https://git.eclipse.org/r/88450
What are the steps to reproduce? If I open Staging view, activate Package Explorer and select something there, Staging view shows the right content.
(In reply to Andrey Loskutov from comment #7) > What are the steps to reproduce? If I open Staging view, activate Package > Explorer and select something there, Staging view shows the right content. 1. Git staging view not active 2. Right click project -> Team -> Commit 3. Staging view pops up and either says "no project selected" or has the wrong project selected 4. Close staging view and reopen, correct project is shown 5. Right click on 1 or more unstaged files and stage them. 6. Normally the files would move to the "staged changed" box but they stay in "unstaged changes" until you close and re-open git staging view. 7. Similarly when you click "Commit" or "Commit and push" the commit does not happen until you close the git staging view (used to happen straight away)
(In reply to Andrey Loskutov from comment #7) > What are the steps to reproduce? If I open Staging view, activate Package > Explorer and select something there, Staging view shows the right content. Or: * Have both staging view and repositories view visible. Staging view bottom right, in the pane with the problems/console/etc; repo view in left pane below the package explorer. * Click on a repo in the repo view. Staging view should update. * Activate some other view in the bottom-right pane: click on the console tab. * Click on some other repo in the (still visible) repositories view. * Click on the staging view tab: comes up still showing the previously shown repository, not the newly selected one.
(In reply to Tom Ford from comment #8) > 1. Git staging view not active > 2. Right click project -> Team -> Commit Tom, I cannot reproduce that one with the Team -> Commit action with current master. And in fact I think it also should not occur with 4.6.0.201612231935-r; what you describe sounds like bug 491907. Do you have "link with selection" enabled?
(In reply to Thomas Wolf from comment #10) > (In reply to Tom Ford from comment #8) > > 1. Git staging view not active > > 2. Right click project -> Team -> Commit > > Tom, I cannot reproduce that one with the Team -> Commit action with current > master. And in fact I think it also should not occur with > 4.6.0.201612231935-r; what you describe sounds like bug 491907. Do you have > "link with selection" enabled? I tried with "link with selection" enabled and disabled and the problem persisted. As an aside, this morning I have spent time moving from Mars.2 to Neon.2 and have so far not had any of these problems occur in Neon although I am currently using EGit 4.4.1.201607150455 from the Neon update site rather than installing the latest from the Egit update site which I had done in Mars.
Gerrit change https://git.eclipse.org/r/88450 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=fff3ed5f6dcb7aa62f22e98bcd509840ced523a2
(In reply to Thomas Wolf from comment #9) > (In reply to Andrey Loskutov from comment #7) > > What are the steps to reproduce? If I open Staging view, activate Package > > Explorer and select something there, Staging view shows the right content. > > Or: > > * Have both staging view and repositories view visible. Staging view bottom > right, in the pane with the problems/console/etc; repo view in left pane > below the package explorer. > * Click on a repo in the repo view. Staging view should update. > * Activate some other view in the bottom-right pane: click on the console > tab. > * Click on some other repo in the (still visible) repositories view. > * Click on the staging view tab: comes up still showing the previously shown > repository, not the newly selected one. Yep. Thanks for the patch!
Last patch causes a severe regression: staging view doesn't react anymore on changing editors. The code in partActivated need to be partly restored, selection change events alone aren't enough.
New Gerrit change created: https://git.eclipse.org/r/88695
Gerrit change https://git.eclipse.org/r/88695 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=cefb94f242e015aec561edda2990af011335a61d
Resolving 3rd time, hopefully last one :-)
thanks for fixing
