Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349741 - Utility jars in EAR50/lib or EAR/ not listed in in EAR Java EE Module Dependencies
Summary: Utility jars in EAR50/lib or EAR/ not listed in in EAR Java EE Module Depende...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.0.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0.5 P   Edit
Assignee: Diego Sahagun CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-17 18:08 EDT by Diego Sahagun CLA
Modified: 2011-09-01 13:24 EDT (History)
2 users (show)

See Also:
cbridgha: review+
ccc: review+

Attachments
Fix for Util Jar population and in-lib-dir checkbox in Java EE Module Dependencies page (4.65 KB, patch)
2011-06-22 17:28 EDT, Diego Sahagun CLA 		no flags Details | Diff
Second patch proposal with a few improvements (9.23 KB, patch)
2011-08-23 15:04 EDT, Diego Sahagun CLA 		shr31223: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Sahagun CLA 2011-06-17 18:08:14 EDT 
Build Identifier: 3.4.2.R342_v20090122

More details coming soon

Reproducible: Always
Comment 1 Carl Anderson CLA 2011-06-17 21:46:28 EDT 
Note that in WTP 3.1, the Java EE Module Dependencies was replaced by the Deployment Assembly properties page.
Comment 2 Roberto Sanchez Herrera CLA 2011-06-18 19:54:14 EDT 
An adopter has reported this problem in WTP 305. The code to display these entries was introduced as part of bug 241335, but it looks like this code did not take into account the case where the EAR content directory is the EAR project itself (i.e. when the content directory field of the new EAR project is empty)
Comment 3 Diego Sahagun CLA 2011-06-22 17:22:21 EDT 
Logic while showing Utility jars when the ear has no Content directory specified (root directory of the ear is the content dir) is not considered, also the logic to show whether if the Jar is in lib dir or not doesn't consider this case.
Comment 4 Diego Sahagun CLA 2011-06-22 17:28:44 EDT 
Created attachment 198435 [details]
Fix for Util Jar population and in-lib-dir checkbox in Java EE Module Dependencies page
Comment 5 Chuck Bridgham CLA 2011-07-11 10:29:13 EDT 
Diego - there were some problems with this initial patch...  let me know when you have resubmitted.
Comment 6 Diego Sahagun CLA 2011-08-23 15:04:14 EDT 
Created attachment 202029 [details]
Second patch proposal with a few improvements
Comment 7 Chuck Bridgham CLA 2011-08-24 15:18:28 EDT 
I reviewed the code - and it looks ok, but when I tested I have more questions.....

I see the jar's show up in the Ear's property page... but in the case of a lib directory set to root "", the Ear Libraries java container isn't working...  maybe this is a different problem.
Comment 8 Chuck Bridgham CLA 2011-08-24 15:48:34 EDT 
ok my tests went ok....  I'm approving this
Comment 9 Roberto Sanchez Herrera CLA 2011-09-01 13:21:28 EDT 
Code committed and released to R3_0_5_patches
Comment 10 Roberto Sanchez Herrera CLA 2011-09-01 13:24:17 EDT 
Resolving because the code was already committed.