349724 – Support or at least omit <source> sections

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 349724 - Support or at least omit <source> sections

Summary: Support or at least omit <source> sections

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Mylyn (show other bugs)
Version:	unspecified
Hardware:	PC Windows 7

Importance:	P3 enhancement (vote)
Target Milestone:	1.5.1
Assignee:	David Green
QA Contact:	David Green

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-06-17 15:41 EDT by John Arthorne
Modified:	2013-10-30 16:39 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
mylyn/context/zip (60.20 KB, application/octet-stream) 2011-06-22 12:21 EDT, David Green	no flags	Details
mylyn/context/zip (3.88 KB, application/octet-stream) 2011-06-22 22:49 EDT, David Green	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description John Arthorne

2011-06-17 15:41:53 EDT

The eclipse wiki has the wikimedia syntax highlighting extension installed. This allows you to write blocks like this:

<source lang="javascript">
  var serviceImpl = {
    run: function(text) {
      return text.split("").reverse().join("");
    }
  };
</source>

And have it syntax highlighted like javadoc.

Currently WikiText converts this to:

		<p>&lt;source lang="javascript"&gt;</p>
		<pre> var serviceImpl = {
   run: function(text) {
     return text.split("").reverse().join("");
   }
 };
</pre>
		<p>&lt;/source&gt;</p>

Comment 1 John Arthorne

2011-06-17 15:43:19 EDT

While in an ideal world I would get syntax highlighted HTML, I would be quite happy if it just ommitted the <source></source> tags entirely so we can at least have nice syntax highlighting on wiki.eclipse.org.

Comment 2 David Green

2011-06-22 12:21:43 EDT

Source blocks are now implemented as a preformatted block with the appropriate CSS class.  Contents of the block are emitted as characters (ie: the source is not syntax-highlighted)

Comment 3 David Green

2011-06-22 12:21:46 EDT

Created attachment 198419 [details]
mylyn/context/zip

Comment 4 John Arthorne

2011-06-22 13:12:02 EDT

Awesome, thanks!

Comment 5 Steffen Pingel

2011-06-22 13:32:00 EDT

David, if you want to include the change in 1.5.1 you have to cherry pick the commit onto the e_3_7_m_3_6_x branch. Otherwise the milestone should be set to 1.6.0.

Comment 6 David Green

2011-06-22 22:49:23 EDT

Created attachment 198439 [details]
mylyn/context/zip

Comment 7 David Green

2011-06-24 17:37:22 EDT

Thanks Steffen.  Cherry picked, rebased to e_3_7_m_3_6_x.

Comment 8 Steffen Pingel

2011-06-25 05:21:06 EDT

I'm not sure what that means but I don't see the commit on the branch. All that needs to happen is to cherry pick the commits for this task. Rebasing should not be required (and is actually harmful for pushed branches).

Comment 9 Steffen Pingel

2011-06-25 05:24:18 EDT

Sorry, my bad, I was looking at the wrong thing. Looks good now! Thanks.

Comment 10 Steffen Pingel

2011-06-25 05:28:44 EDT

David, did this change introduce new API? If that is the case we can not make it available in 1.5.1 but we can only apply the change for 1.6.

Comment 11 David Green

2011-06-29 15:29:38 EDT

Ag, I missed that - sorry.  I can refactor it for 1.5.1 so that it doesn't involve new API, (but keeps the new API for 1.6)

Comment 12 David Green

2011-06-29 16:01:44 EDT

Removed new API in 1.5.1 on branch e_3_7_m_3_6_x and fixed @since tag on new api on branch master (set to 1.6)

that should be it for this one.

Comment 13 David Green

2011-06-29 16:14:16 EDT

for future reference, versioning should follow "these guidelines":http://wiki.eclipse.org/Version_Numbering which require the minor segment to change whenever there are externally visible changes (eg: API additions)

Comment 14 Steffen Pingel

2011-06-30 01:58:35 EDT

Thanks David. If you set an API baseline you can easily detect these type of errors in your workspace.