Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349713 - NPE due to password case sensitivity change
Summary: NPE due to password case sensitivity change
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: 0.2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-17 14:02 EDT by John Arthorne CLA
Modified: 2011-09-01 11:42 EDT (History)
1 user (show)

See Also:
Szymon.Brandys: review+

Attachments
Fix v01 (1.37 KB, patch)
2011-06-17 14:11 EDT, John Arthorne CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-06-17 14:02:00 EDT 
I'm seeing a ton of errors like this in the log on orion.eclipse.org. This is related to the change to support case-insensitive passwords.


java.lang.NullPointerException: null
        at org.eclipse.orion.internal.server.user.securestorage.SecureStorageCredentialsService.findNodeIgnoreCase(SecureStor
ageCredentialsService.java:201) ~[na:na]
        at org.eclipse.orion.internal.server.user.securestorage.SecureStorageCredentialsService.getUser(SecureStorageCredenti
alsService.java:167) ~[na:na]
        at org.eclipse.orion.internal.server.user.securestorage.SecureStorageCredentialsService.getUser(SecureStorageCredenti
alsService.java:1) ~[na:na]
        at org.eclipse.orion.server.authentication.form.core.FormAuthHelper.getUserForCredentials(FormAuthHelper.java:134) ~[
na:na]
        at org.eclipse.orion.server.authentication.form.core.FormAuthHelper.performAuthentication(FormAuthHelper.java:104) ~[
na:na]
        at org.eclipse.orion.server.authentication.form.servlets.LoginServlet.doPost(LoginServlet.java:46) ~[na:na]
Comment 1 John Arthorne CLA 2011-06-17 14:11:07 EDT 
I think the only possibility is that "login" is null.
Comment 2 John Arthorne CLA 2011-06-17 14:11:38 EDT 
Created attachment 198203 [details]
Fix v01
Comment 3 John Arthorne CLA 2011-06-17 14:37:37 EDT 
I have entered bug 349719 to investigate why this isn't being caught earlier. Ideally the dialog would not even POST to the server if the user has not provided a login. However this null check is still worthwhile.