Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349705 - [client] Remove /org.dojotoolkit dependency from examples
Summary: [client] Remove /org.dojotoolkit dependency from examples
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-17 12:24 EDT by Mark Macdonald CLA
Modified: 2011-09-01 11:42 EDT (History)
1 user (show)

See Also:
simon_kaegi: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-06-17 12:24:59 EDT 
The examples (embeddededitor.html, minimaleditor.html) are picking up dojo through
> <script type="text/javascript" src="/org.dojotoolkit/dojo/dojo.js.uncompressed.js"></script>

This is not consumable, since it assumes that the server you're running the example on will have dojo available at that path.

We should:
- Reference a CDN copy of dojo for the examples.
- Remove CSS imports of dojo stylesheets from the examples. (They're causing a long chain of requests that increases the page load time substantially.)
Comment 1 Mark Macdonald CLA 2011-06-17 15:54:11 EDT 
Here is a patch:

http://git.eclipse.org/c/e4/org.eclipse.orion.client.git/commit/?h=bug349705

It uses Dojo 1.6 from Google's CDN and removes the dojo/dijit stylesheets.
Adds a CSS rule to make the font & spacing in the examples look the same as before.
Comment 2 Mark Macdonald CLA 2011-06-20 14:46:23 EDT 
Removed the CDN link due to legal questions.

I'll just use this bug to remove the imports of Dojo css files, so the examples will load a bit faster.