Comment 1 libing wang 2011-06-17 10:52:26 EDT

If a git repo does not have a remote , we should not render the mini log section at all , including the header part .

Comment 2 Simon Kaegi 2011-06-17 10:57:43 EDT

We need to be a bit careful here. It's not just the lack of a remote. It's also the lack of a tracked remote branch.

Comment 3 libing wang 2011-06-17 11:33:49 EDT

(In reply to comment #2)
> We need to be a bit careful here. It's not just the lack of a remote. It's also
> the lack of a tracked remote branch.

Simon , that is different scope. If there is no tracked remote branch , we will still have this mini log section but the log content will say "no remote branch found :origin/branchName". Going to complete log will show the same thing.

Comment 4 libing wang 2011-06-17 11:42:59 EDT

We had a bug on lack of tracked remote branch before at bug 349106 , which was fixed just today.
Please see comment 3 and comment 4 at bug 349106.
I think for the " lack of a tracked remote branch" issue ,that is the best we can do for RC2.

Comment 5 libing wang 2011-06-17 11:51:38 EDT

If a git repo does not have a remote , we should not render the mini log section at all , including the header part .

Comment 6 libing wang 2011-06-17 11:54:00 EDT

*** Bug 349698 has been marked as a duplicate of this bug. ***

Comment 7 John Arthorne 2011-06-17 14:41:06 EDT

With this patch, if I go to "Git Log", and then click "Switch to Remote", I get garbage appearing in the UI. I don't know if it is related but actually looks worse than the original problem of an empty list in the status page.

Comment 8 John Arthorne 2011-06-17 14:42:55 EDT

Created attachment 198205 [details]
Screen shot of remote log for repo with no remote

This does seem related to your patch. Running on master I just get a 404. Running with your patch I get this.

Comment 9 Boris Bokowski 2011-06-17 15:14:47 EDT

(In reply to comment #8)
> Created attachment 198205 [details]
> Screen shot of remote log for repo with no remote

I can reproduce this on orion.eclipse.org (without Libing's patch).

Comment 10 Simon Kaegi 2011-06-17 17:50:25 EDT

Where are we here? 
Is there a patch that I can look at on a branch? Was there something partially committed for RC2?

Comment 11 Boris Bokowski 2011-06-17 21:44:49 EDT

I looked at the problem, and the proposed patch, and decided that it wasn't severe enough a problem that we needed to fix it last thing for RC2. We can talk about it on Monday to decide if we want to fix it for RC3 or after 0.2.

Comment 12 libing wang 2011-06-20 17:05:42 EDT

(In reply to comment #11)
> I looked at the problem, and the proposed patch, and decided that it wasn't
> severe enough a problem that we needed to fix it last thing for RC2. We can
> talk about it on Monday to decide if we want to fix it for RC3 or after 0.2.

When I fixed bug 349810 today , I've touched the same code as Branch bug349693 did.So I had to create another branch and fix this bug on top of bug 349810's fix.

I've pushed the fix to the branch called Bug349693_New.
Waiting for reviews from John and Boris.

Comment 13 Boris Bokowski 2011-06-20 17:33:02 EDT

+1 from me, after talking about this with Simon we agreed that it should be fixed for 0.2. I have reviewed the change.

Comment 14 Boris Bokowski 2011-06-20 17:33:47 EDT

I think the "-" from John no longer applies, see comment 9.

Libing, you can go ahead and merge/push this commit.

Comment 15 Simon Kaegi 2011-06-20 17:55:11 EDT

I've pushed this now.