Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349674 - Reject NavigationNodes without NavigationNodeIds
Summary: Reject NavigationNodes without NavigationNodeIds
Status: NEW
Alias: None
Product: Riena
Classification: RT
Component: navigation (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.0.0.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-17 07:51 EDT by Steffen Kriese CLA
Modified: 2011-06-17 07:51 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Kriese CLA 2011-06-17 07:51:50 EDT 
Riena assumes that every NavigationNode is unique, that means it is identified by its NavigationNodeId. But at the moment it is possible to create a NavigationNode without a NavigsationNodeId or pass in null. Those nodes can't be found in the navigationtree by using methods like NavigationNode.findNode() and can lead to other problems described in Bug #349504.

In my opinion we do a fail fast and reject this, by throwing a RuntimeException if the NavigationNodeId is null at any point.

Any thoughts or comments on this?