Community
Participate
Working Groups
Working with GitHandlers has become cumbersome as more features are added and more HTTP methods gets supported. The trickiest part is handling paths sent as the part of a URI or as a parameter. Translating them to a Orion file or workspace path can be a real pain. The code is cluttered with bunch of utility methods like those from GitUtils class or different flavors of BaseToXConverters. A solution to that may an introduction of object that would represent certain entities in git logic. Here are some examples: * WebClone (already have it) * Branch * Remote * Diff * Commit * ... All of them (except for the first one) would be derivative of a WebClone so they operate in a proper context. In other words, a Diff object can be created only for an concrete WebClone. Each object will have a method to serialize it to JSON which would simplify creating responses. This should help fixing bug 345402 and bug 349290.
(In reply to comment #0) > A solution to that may an introduction of object that would represent certain > entities in git logic. Here are some examples: > * WebClone (already have it) > * Branch > * Remote These two and RemoteBranch have been already added on http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/?h=bug353557 while working on bug353557.
(In reply to comment #1) > These two and RemoteBranch have been already added on > http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/?h=bug353557 http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/?h=bug353557 has been merged into master as http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=4587f17f7c9ad1a34cb2a04492000175cf620805
Fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=816cdd97c39c18fb0e8c44ee77e284ba51e7067f.
*** Bug 345402 has been marked as a duplicate of this bug. ***
