Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349641 - Layout of editor.actions is a bit off
Summary: Layout of editor.actions is a bit off
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 RC1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 22:52 EDT by Simon Kaegi CLA
Modified: 2012-02-03 03:57 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2011-06-16 22:52:21 EDT 
I noticed that layout for editor actions seemed a bit strange. First, after adding an editor action there is a new white bar very close to the save button. Second I don't see icons. Perhaps we decided we only wanted text here??
Comment 1 Boris Bokowski CLA 2011-06-17 09:07:21 EDT 
Yes I think we decided only text in the toolbar.
Comment 2 Susan McCourt CLA 2012-01-30 18:10:18 EST 
compare editors are still showing the editor action icon vs. text.  Need to fix that.  Will do a pass once we have a reasonable guideline we can explain for when icons are used in the toolbar and how the developer can force an icon.
Comment 3 Susan McCourt CLA 2012-02-03 02:41:58 EST 
(In reply to comment #2)
> compare editors are still showing the editor action icon vs. text.  Need to fix
> that.  Will do a pass once we have a reasonable guideline we can explain for
> when icons are used in the toolbar and how the developer can force an icon.

For now we use text unless there is none specified (not common).
I also noticed that the old separator gif was not showing (it was white on white).  Changed it to be gray.  It needs some polish, tracked in bug 370481.
Comment 4 Susan McCourt CLA 2012-02-03 03:57:10 EST 
pushed fix.