Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349584 - Rename refactoring doesn't work with STRING Type
Summary: Rename refactoring doesn't work with STRING Type
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: SR1   Edit
Assignee: Jan Koehnlein CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 11:32 EDT by Veit Hoffmann CLA
Modified: 2017-09-19 18:03 EDT (History)
3 users (show)

See Also:
sebastian.zarnekow: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Veit Hoffmann CLA 2011-06-16 11:32:37 EDT 
Build Identifier: 2.0.0.v201105030849

If the key attribute of an element is encoded as org.eclipse.xtext.common.Terminals::STRING the rename refactoring converts the the value of the key attribute to ID. This breaks the parsetree.

This only happens in the declaration of the element. All other occurences of the String are refactored correctly.   


Reproducible: Always

Steps to Reproduce:
1. Change example DSL to 'Hello' name=STRING '!';
2. Enabale refactoring
3. Refactor name
Comment 1 Sebastian Zarnekow CLA 2011-06-16 11:36:22 EDT 
Does this still happen with the latest builds?
Comment 2 Veit Hoffmann CLA 2011-06-17 05:30:35 EDT 
This behavior still holds true for the current Xtext Version on the Indigo Update Site: 2.0.0.v201106010845 and current nightly buid 2.0.0.v201106050907
Comment 3 Jan Koehnlein CLA 2011-07-05 09:17:12 EDT 
We have to use the value converter in the refactoring strategy.

Fix pushed to MASTER.
Comment 4 Karsten Thoms CLA 2017-09-19 17:53:05 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 5 Karsten Thoms CLA 2017-09-19 18:03:48 EDT 
Closing all bugs that were set to RESOLVED before Neon.0