Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349578 - [client] Flashing in status page on push
Summary: [client] Flashing in status page on push
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 11:03 EDT by John Arthorne CLA
Modified: 2011-09-01 11:41 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-06-16 11:03:46 EDT 
I20110616

When I push a change from the page, various parts of the page flash and redraw for a couple of seconds. It looks like far too many refreshes are happening after a push.
Comment 1 Boris Bokowski CLA 2011-06-16 14:58:03 EDT 
We should investigate what it would take to fix this. I just got this flashing too, it is very distracting.
Comment 2 Boris Bokowski CLA 2011-06-16 14:58:35 EDT 
investigate, as in: what is the minimal code change that would fix the problem, or improve the situation considerably?
Comment 3 John Arthorne CLA 2011-06-17 10:01:44 EDT 
I have been keeping an eye on it, and I have only seen it so far on push. Fetch and merge don't seem to cause the problem.
Comment 4 libing wang CLA 2011-06-17 11:36:13 EDT 
Taking this priority today.Investigating now , try to fix it in RC2.
Comment 5 libing wang CLA 2011-06-17 13:43:28 EDT 
Found the problem :
At the end of the push command call back chain , I've put the status UI refresh call back in side [[dojo.query(".treeTableRow").forEach(function(node, i) {]].
Moving the callback outside of the .forEach resolved the issue.
Comment 6 Boris Bokowski CLA 2011-06-17 15:07:56 EDT 
+1 for RC2, I reviewed the fix.
Comment 7 libing wang CLA 2011-06-17 15:46:25 EDT 
fixed with a8c7fcdbfd69eabd43b874dc2330a6df45199400