Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349558 - Engine will cyclically accept the same type more then once
Summary: Engine will cyclically accept the same type more then once
Status: CLOSED INVALID
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.2.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 09:25 EDT by Ian Tewksbury CLA
Modified: 2011-06-16 12:32 EDT (History)
0 users

See Also:

Attachments
Patch (3.21 KB, patch)
2011-06-16 09:27 EDT, Ian Tewksbury CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2011-06-16 09:25:34 EDT 
Currently the Engine implementation will accept a type, and then when it calls the lookupEnviorment#buildTypeBindings it can accept that type again.  This duplicate work should be prevented.
Comment 1 Ian Tewksbury CLA 2011-06-16 09:27:56 EDT 
Created attachment 198095 [details]
Patch

patch to prevent the cyclic accepting of units.  Passes all existing JUnits.
Comment 2 Ian Tewksbury CLA 2011-06-16 09:50:22 EDT 
It seems this patch breaks some of the JUnits I have written for Bug 306958
Comment 3 Ian Tewksbury CLA 2011-06-16 10:07:55 EDT 
I guess this fix will have to hold off.  It seems for some reason if we prevent this cycle then the return types for constructors in files other then the one content assist is being invoked for do not get set.
Comment 4 Ian Tewksbury CLA 2011-06-16 12:32:42 EDT 
Chris tells me this has been done on purpose...