Community
Participate
Working Groups
Hi, We need to be able to create Java Query from the EMF Facet wizards. A wizard page should be contributed for JavaQuery. Regards, Nicolas Guyomar
Created attachment 198098 [details] org.eclipse.emf.facet.query.java.ui.zip Hi, Please find attached plug-in org.eclipse.emf.facet.query.java.ui which contains the wizard page to create JavaQuery. Authors of this contribution are Gregoire Dupe (commiter), Nicolas Bros (commiter) and myself. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Created attachment 198099 [details] org.eclipse.emf.facet.query.java.ui.tests Hi, Please find attached a new set of SWTBot test in plug-in org.eclipse.emf.facet.query.java.ui.tests. Those new tests checks all EMF Facet wizards. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Created attachment 198100 [details] Patch for Bug 349556 xfriends Hi, Both preceding contribution need some new x-friends to be added to plug-in org.eclipse.emf.facet.util.core, here is a patch to do so. (a) I, Nicolas Guyomar, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features. Regards, Nicolas Guyomar
Comment on attachment 198098 [details] org.eclipse.emf.facet.query.java.ui.zip I validate this patch with the following reservation: The wizard pages don't flow naturally, and the wizard doesn't feel cohesive. As a result, the user risks getting lost in the process. There are two main cases when creating a Facet: * I want to use an existing query : - I open the create Facet wizard - I click on "..." in the Java class name field : this opens a second wizard - I click on "Select an existing Java class" - And then I can only click on Finish: this opens another dialog that replaces the second wizard. Notice that the second wizard was only used to select an option to replace the wizard by another dialog box. I think this choice could be done in the first wizard, maybe by using radio buttons : "Create a new query" and "Use an existing query" * I want to create a new query : - I open the create Facet wizard - I click on "..." in the Java class name field : this opens a second wizard - I click on "Create a new Java class" - I click Next and go to the second page where I can specify the class name, package, etc. - I click Finish in the class creation wizard. But this does not yet create the class! I think this is not the way wizards are supposed to work, and as a result users don't expect this behavior: when clicking "Finish", the action should always be performed immediately. So this means that a second wizard is probably not a good fit for this. I think the problem could be solved by: - removing the second wizard - adding a choice in the "Create Query" page in the first wizard, between "Create a new query class" and "Use an existing query class" - moving the "New Java class" page from the second wizard into the first, after "Create a new query class" is selected - moving the contents of the class selection dialog into a new page on the first wizard, after "Use an existing query class" is selected
Comment on attachment 198098 [details] org.eclipse.emf.facet.query.java.ui.zip This is a contribution from an employee of Mia-Software, targeting a future Juno release. The company has signed a Member Committer Agreement. The contribution does not need a CQ (see bug 322327). Committed in revision 875.
Comment on attachment 198099 [details] org.eclipse.emf.facet.query.java.ui.tests This is a contribution from an employee of Mia-Software, targeting a future Juno release. The company has signed a Member Committer Agreement. The contribution does not need a CQ (see bug 322327). Committed in revision 875.
Comment on attachment 198100 [details] Patch for Bug 349556 xfriends This is a contribution from an employee of Mia-Software, targeting a future Juno release. The company has signed a Member Committer Agreement. The contribution does not need a CQ (see bug 322327). Committed in revision 875.
This bug can be closed.
