Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349553 - Java compiler warning - redundant modifier
Summary: Java compiler warning - redundant modifier
Status: RESOLVED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 08:34 EDT by Nikolay Metchev CLA
Modified: 2011-06-20 09:48 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolay Metchev CLA 2011-06-16 08:34:27 EDT
It would be good to be able to configure the compiler to emit warnings on redundant modifiers (such as public on interface fields).
Comment 1 Ayushman Jain CLA 2011-06-16 10:46:44 EDT
I don't think its a very good idea to have the compiler emit such specific warnings. I think its better if other static analysis tools such as FindBugs, etc do this. Too much fine grained analysis will unnecessary slow down the compiler even for those who don't stand to gain anything from such a warning.
Comment 2 Nikolay Metchev CLA 2011-06-16 10:54:00 EDT
Surely if you set the setting to "Ignore" then there should be no slow down. Unless you are telling me that the compiler evaluates all warnings/errors regardless of the level they are set to.
Comment 3 Markus Keller CLA 2011-06-16 11:15:19 EDT
The redundant modifiers don't harm other than being redundant, and a warning for them would rarely help finding a real problem in the vicinity. I think the Clean Up / Save Action from bug 267335 would be good enough to deal with this.
Comment 4 Ayushman Jain CLA 2011-06-20 09:48:44 EDT
(In reply to comment #3)
> The redundant modifiers don't harm other than being redundant, and a warning
> for them would rarely help finding a real problem in the vicinity. I think the
> Clean Up / Save Action from bug 267335 would be good enough to deal with this.

+1 for a clean up.

Closing this as WONTFIX.