Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349519 - ti.catalog.c2800.init.Boot.xs this.$logError() needs to be updated
Summary: ti.catalog.c2800.init.Boot.xs this.$logError() needs to be updated
Status: CLOSED FIXED
Alias: None
Product: RTSC
Classification: Technology
Component: Platforms (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Scott Gary CLA
QA Contact:
URL:
Whiteboard: target:3.23.04
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 01:03 EDT by Karl Wechsler CLA
Modified: 2013-01-24 15:11 EST (History)
2 users (show)

See Also:

Attachments
picture of the problem (101.00 KB, application/powerpoint)
2011-06-16 01:03 EDT, Karl Wechsler CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Wechsler CLA 2011-06-16 01:03:43 EDT 
Created attachment 198062 [details]
picture of the problem

See attached .ppt.   I think that this.$logError should be changed to BIOS.$logError().
Comment 1 Sasha Slijepcevic CLA 2011-11-09 16:45:13 EST 
- fixed in platform-n08

Usually in a module's function, 'this' refers to that module. However, in this case, a module function is invoked from a private capsule function without setting 'this' to the module. As a consequence, 'this' stays a reference to a capsule, and cannot be used as a parameter to $logError.
Comment 2 Karl Wechsler CLA 2011-11-15 16:57:10 EST 
Sasa fixed the 'this' vs 'BIOS' problem, so it's not fair to mark this verify-fail, but I'm going to anyway since there's a 2nd issue.

I think the last parameter of all the logError() calls in this Boot.xs file needs to specify the module name followed by the short field name instead of the single long name shown today.  This is necessary so that xgconf will show the error or warning as appropriate.

There are several examples of this in the Boot.xs file.

I think this:

       Boot.$logWarning("\nPLL configuration is not supported for this PLL " +
           "type.  Setting configurePll to true will have no effect.",
           "ti.catalog.c2800.init.Boot.configurePll");

should be change to this:

       Boot.$logWarning("\nPLL configuration is not supported for this PLL " +
           "type.  Setting configurePll to true will have no effect.", Boot,
           "configurePll");
Comment 3 Scott Gary CLA 2012-05-08 19:13:42 EDT 
Looking at the Boot.xs file (in platform-n20/src/ti/catalog/c2800/init), this has already been fixed by someone:

       Boot.$logWarning("\nPLL configuration is not supported for this PLL " +
           "type.  Setting configurePll to true will have no effect.", Boot,
           "configurePll");

I also looked at this in XGCONF and see the correct behavior.

Moving to RESOLVED...
Comment 4 Dave Russo CLA 2013-01-24 15:11:54 EST 
xdctools 3.23.05 GA is available from here: http://www.sanb.design.ti.com/tisb_releases/XDCtools/3_23_05_61/