Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349491 - possible NPE on shutdown due to event firing
Summary: possible NPE on shutdown due to event firing
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.1   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 15:00 EDT by David McKnight CLA
Modified: 2011-06-16 09:51 EDT (History)
1 user (show)

See Also:
xuanchen: review+

Attachments
patch to check for active registry (1.68 KB, patch)
2011-06-15 15:05 EDT, David McKnight CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David McKnight CLA 2011-06-15 15:00:40 EDT 
From the RemoteCmdSubSystem events are fired when shells are disconnected.  During a shutdown, it's possible for system registry to be inactive.  If that's the case, then the events should not be fired.
Comment 1 David McKnight CLA 2011-06-15 15:05:47 EDT 
Created attachment 198047 [details]
patch to check for active registry
Comment 2 David McKnight CLA 2011-06-15 15:57:13 EDT 
Xuan, could you please review this.  The change is pretty trivial and low-risk so I think we only need one reviewer.
Comment 3 Xuan Chen CLA 2011-06-15 17:30:02 EDT 
The fix looks good.  Thanks.
Comment 4 David McKnight CLA 2011-06-16 09:51:54 EDT 
Thanks for the review, Xuan.  I've committed the change to the HEAD stream.