Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349473 - task outline selection does not focus on comment for a task with many comments
Summary: task outline selection does not focus on comment for a task with many comments
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.6.2   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 12:05 EDT by Thomas Ehrnhoefer CLA
Modified: 2011-08-26 18:39 EDT (History)
2 users (show)

See Also:

Attachments
mylyn/context/zip (2.43 KB, application/octet-stream)
2011-08-26 18:39 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Ehrnhoefer CLA 2011-06-15 12:05:49 EDT 
Selecting an element (e.g a comment or a task attribute) in the outline of the Task Editor should focus the task editor on that attribute editor.
Comment 1 Sam Davis CLA 2011-06-15 12:09:28 EDT 
This works for in many cases, but does not work for comments if there are a lot of them (~20) on the task.
Comment 2 Thomas Ehrnhoefer CLA 2011-06-15 12:22:04 EDT 
Ah, my bad. So maybe it's the comment folding (subsections) that screwes this up?
Comment 3 Steffen Pingel CLA 2011-06-15 12:39:27 EDT 
Can you provide steps to reproduce with an Eclipse.org bug?
Comment 4 Sam Davis CLA 2011-06-15 13:44:42 EDT 
* open bug 162007
* ctrl+o
* type sam
* use down arrow to select comment 13 and push enter
* comment 13 is not expanded
Comment 5 Thomas Ehrnhoefer CLA 2011-06-15 13:46:40 EDT 
This actually works for me Sam, odd. I am bootstrapped on mylyn e_3_7_m_3_5_x
Comment 6 Steffen Pingel CLA 2011-06-15 14:09:52 EDT 
Looks like this is a regression introduced by bug 237546.
Comment 7 Sam Davis CLA 2011-06-15 14:10:51 EDT 
I am on HEAD. It works for me if I expand "Recent" first.
Comment 8 Steffen Pingel CLA 2011-08-26 18:39:33 EDT 
Steps to reproduce bug (adapted from comment 4 for users who are are not Sam):

* open bug 162007
* ctrl+o
* type mik
* use down arrow to select comment 1 and push enter
* comment 1 is not expanded

Committed a fix to master and e_3_7_m_3_6_x branch.
Comment 9 Steffen Pingel CLA 2011-08-26 18:39:35 EDT 
Created attachment 202257 [details]
mylyn/context/zip