Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349470 - [client] editorFeatures depends implicitly on core bundle
Summary: [client] editorFeatures depends implicitly on core bundle
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 11:55 EDT by Mark Macdonald CLA
Modified: 2011-09-01 11:42 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-06-15 11:55:33 EDT 
The AnnotationFactory in editorFeatures.js creates error markers using the following URL:
> <img src='/images/problem.gif'

The gif file is located in the core bundle. This should be refactored so that you can consume the AnnotationFactory without requiring anything outside the editor bundle.
Comment 1 Susan McCourt CLA 2011-06-15 12:16:14 EDT 
we should just copy the icon to the editor.
Comment 2 Mark Macdonald CLA 2011-06-15 12:55:17 EDT 
(In reply to comment #1)
> we should just copy the icon to the editor.

Agree
Comment 3 Susan McCourt CLA 2011-06-15 13:36:24 EDT 
+1 in advance, it's just an icon copy.
Please double check the main orion editor as proof that you didn't accidentally move it.  ;-)
Comment 4 Susan McCourt CLA 2011-06-15 14:08:21 EDT 
It wasn't just an icon copy.
Reviewed with Mark.
Bogus that we had hardcoded images in the AnnotationFactory, so this is the right fix and is very important for consumability.

+1 for RC2.