Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349457 - InternalTreeModelViewer.handleTreeExpand() prints "dude" to System.out
Summary: InternalTreeModelViewer.handleTreeExpand() prints "dude" to System.out
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 3.7.1   Edit
Assignee: Pawel Piech CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 11:11 EDT by Mirko Seifert CLA
Modified: 2011-07-21 12:12 EDT (History)
2 users (show)

See Also:
Michael_Rennie: review+


Attachments
Fix. (992 bytes, patch)
2011-07-20 12:02 EDT, Pawel Piech CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mirko Seifert CLA 2011-06-15 11:11:05 EDT
Build Identifier: I20110526-1708

If a tree item does not have data (event.item.getData() == null) the handleTreeExpand() method prints "dude" to System.out.

I think it should either ignore this, write a decent entry to the error log, or print a meaningful message.

Reproducible: Always

Steps to Reproduce:
Either write a custom debugger that create tree item with no data or write a custom JUnit test that calls an instance of InternalTreeModelViewer with the appropriate arguments.

In any case the bug is obvious from the code.
Comment 1 Pawel Piech CLA 2011-06-15 19:03:36 EDT
Wow, this is really embarrassing :-(  More so that it's been there since March.
Comment 2 Pawel Piech CLA 2011-07-20 12:02:02 EDT
Created attachment 200019 [details]
Fix.
Comment 3 Pawel Piech CLA 2011-07-20 12:02:52 EDT
I already committed the fix to head.

Mike could you review+ to take the dude out of 3.7 branch?
Comment 4 Michael Rennie CLA 2011-07-21 11:58:35 EDT
+1 for 3.7.1
Comment 5 Pawel Piech CLA 2011-07-21 12:12:27 EDT
The Dude abides...
Comment 6 Pawel Piech CLA 2011-07-21 12:12:44 EDT
Already reviewed.