Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349449 - Icon alignment with text in the navigator
Summary: Icon alignment with text in the navigator
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 10:25 EDT by Simon Kaegi CLA
Modified: 2011-09-01 11:42 EDT (History)
1 user (show)

See Also:
susan: review? (mamacdon)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2011-06-15 10:25:16 EDT 
We were looking at the new icons today (generally great) and McQ pointed out an alignment issue with text at least in the navigator view and likely others. We saw this in Safari and Chrome.
Comment 1 John Arthorne CLA 2011-06-15 10:28:59 EDT 
Also in the Repositories view it is particularly bad. The text almost touches the icon in this view.
Comment 2 Susan McCourt CLA 2011-06-15 11:14:47 EDT 
I'll take a look.  Turns out this has always been true but position of the icons within the 16x16 box seems to make it more noticeable/worse.

The trick is to find the magic CSS that works well in all browsers, they tend to behave differently with table stuff.
Comment 3 Susan McCourt CLA 2011-06-15 15:28:05 EDT 
the fix is to vertically align all images in the first column.
This is done inline when generating them.
Also added some margin to the right of the model icons, but this only fixes nav, not git clone.

See branch remotes/origin/bug349449
Comment 4 Mark Macdonald CLA 2011-06-15 15:40:22 EDT 
I reviewed the patch and it looks good, +1
Comment 5 Susan McCourt CLA 2011-06-15 15:50:13 EDT 
pushed.(In reply to comment #1)

> Also in the Repositories view it is particularly bad. The text almost touches
> the icon in this view.

My fix handles expandable nodes but not leaf nodes.  Opened bug 349498 for looking at the rest of the git renderers.