Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349435 - Namespace editing dialog doesn't parent the dialog shell correctly
Summary: Namespace editing dialog doesn't parent the dialog shell correctly
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xml (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.1   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-15 09:36 EDT by Remy Suen CLA
Modified: 2011-06-15 11:12 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-06-15 09:36:40 EDT 
1. Open the 'XPath' view.
2. Ctrl+F10 > Edit Namespace Prefixes
3. If you click the 'Add...' button and then hit ESC, the focus is on the workbench window instead of the dialog window.

CommonEditNamespacesDialog's invokeDialog(*) and performNew() methods are bad. I suggest parenting off your own shell or getting a modal shell provider from IWorkbench's getModalDialogShellProvider() method.
Comment 1 Nick Sandonato CLA 2011-06-15 11:12:10 EDT 
Thanks, Remy. Fixed it so the original dialog's shell is used for both invokeDialog() and performNew().