Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349370 - tycho-versions-plugin does not change version for the eclipse-repository packaging type
Summary: tycho-versions-plugin does not change version for the eclipse-repository pack...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Tycho (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Jan Sievers CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 386104 (view as bug list)
Depends on:
Blocks: 342876
  Show dependency tree
 
Reported: 2011-06-14 16:23 EDT by Robert Munteanu CLA
Modified: 2021-04-28 16:54 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Munteanu CLA 2011-06-14 16:23:54 EDT
I've tried setting the version for a tycho project using @mvn org.eclipse.tycho:tycho-versions-plugin:set-version -DnewVersion=$newVersion@ , but the module with @eclipse-repository@ packaging type was not processed and retained the old version.
Comment 1 Igor Fedorenko CLA 2011-06-14 16:35:20 EDT
It only makes sense to fix tycho-versions-plugin after we split eclipse-repository and eclipse-product packaging types and settle on repository descriptor format.
Comment 2 Tobias Oberlies CLA 2011-06-24 07:33:10 EDT
What do you expect to be changed?
- For product definitions, I agree that this needs to wait for the packaging type split (bug 348586).
- There should be no need to change the category.xml - instead one should specify a "0.0.0" version for "latest version". Unfortunately, this is currently broken: bug 350236.
Comment 3 Robert Munteanu CLA 2011-06-24 08:40:44 EDT
For my use case bug 350236 should be enough.
Comment 4 Tobias Oberlies CLA 2011-07-26 05:05:27 EDT
There is nothing left to do:
- We won't replace versions in the category.xml. For latest version, use "0.0.0" (without ".qualifier"!)
- The version in product files needs to be replaced, but this will only be supported in the future eclipse-product packaging type (bug 348586)
Comment 5 Tobias Oberlies CLA 2012-07-27 06:32:09 EDT
*** Bug 386104 has been marked as a duplicate of this bug. ***
Comment 6 Tobias Oberlies CLA 2013-10-18 03:43:14 EDT
I only recently learned that the versions in fact does update references (and opened bug 418013 for the missing documentation). This means that this bug report is in fact valid - it makes sense to expect that the category.xml is updated.

The workaround is to use 0.0.0 as version in the category.xml.
Comment 7 Mickael Istria CLA 2013-10-18 03:46:20 EDT
So should the following Gerrit patch marked as abandonned because of feature already available?
Comment 8 Tobias Oberlies CLA 2013-10-21 11:59:14 EDT
Which feature is available? The category.xml is currently not updated but it should be - this is why this bug report is open.
Comment 9 Mickael Istria CLA 2013-10-23 13:08:23 EDT
Sorry I misread. I submitted a Gerrit patch a while ago on this topic https://git.eclipse.org/r/#/c/6995/
Comment 10 Tobias Oberlies CLA 2014-07-03 12:19:46 EDT
(In reply to comment #9)
> I submitted a Gerrit patch a while ago on this topic
> https://git.eclipse.org/r/#/c/6995/

Sorry, but the patch was only a small part of what is needed to fully implement this. So I decided to re-implement it instead of making you jump through the IP hoops for it:
https://git.eclipse.org/r/#/c/29416/
Comment 12 Jan Sievers CLA 2014-07-14 07:30:22 EDT
trying to use the versions plugin 0.21.0-SNAPSHOT for tycho itself I get:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2:10.705s
[INFO] Finished at: Mon Jul 14 13:26:08 CEST 2014
[INFO] Final Memory: 12M/244M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-versions-plugin:0.21.0-SNAPSHOT:set-version (default-cli) on proj
ect tycho: Execution default-cli of goal org.eclipse.tycho:tycho-versions-plugin:0.21.0-SNAPSHOT:set-version failed: Cou
ld not read categories from c:\git\eclipse\org.eclipse.tycho\tycho-bundles\tycho-standalone-p2-director\category.xml: c:
\git\eclipse\org.eclipse.tycho\tycho-bundles\tycho-standalone-p2-director\category.xml (The system cannot find the file
specified) -> [Help 1]
[ERROR]


Looks like the case of no category.xml (only .product files) needs to be fixed.
Comment 13 Jan Sievers CLA 2014-07-14 09:22:48 EDT
https://git.eclipse.org/r/#/c/29858/