Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349354 - Need to call gdk_cairo_reset_clip when resetting clipping
Summary: Need to call gdk_cairo_reset_clip when resetting clipping
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux-GTK
: P3 normal (vote)
Target Milestone: 3.7.1   Edit
Assignee: Bogdan Gheorghe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 344909 (view as bug list)
Depends on:
Blocks: 333965
  Show dependency tree
 
Reported: 2011-06-14 14:23 EDT by Bogdan Gheorghe CLA
Modified: 2011-10-24 22:28 EDT (History)
5 users (show)

See Also:
Silenio_Quarti: review+

Attachments
Patch (4.20 KB, patch)
2011-08-05 15:51 EDT, Bogdan Gheorghe CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bogdan Gheorghe CLA 2011-06-14 14:23:43 EDT 
GTK 2.18 and greater makes use of nonnative windows. We need to make use of gdk_cairo_reset_clip() instead of directly calling cairo_reset_clip() since calling the latter will "unset the clip region inherited from the drawable (i.e. the window clip region), and thus let you e.g. draw outside your window."
Comment 1 Remy Suen CLA 2011-06-20 11:09:23 EDT 
This showed up while I was searching for Windows bugs. :)
Comment 2 Bogdan Gheorghe CLA 2011-08-05 15:51:07 EDT 
Created attachment 201020 [details]
Patch

Patch for review
Comment 3 Bogdan Gheorghe CLA 2011-08-05 15:59:54 EDT 
Fixed in HEAD and in 3.7 maintenance > 20110805.
Comment 4 Silenio Quarti CLA 2011-10-24 22:28:33 EDT 
*** Bug 344909 has been marked as a duplicate of this bug. ***