Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349339 - [project setup] JSWebResourceEventManager needs to check that the Source entry it creates does not conflict with an existing entry
Summary: [project setup] JSWebResourceEventManager needs to check that the Source entr...
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Web (show other bugs)
Version: 3.2.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.5   Edit
Assignee: Chris Jaun CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-14 11:46 EDT by Chris Jaun CLA
Modified: 2011-09-23 11:40 EDT (History)
0 users

See Also:
thatnitind: review+

Attachments
patch (2.30 KB, patch)
2011-06-14 11:47 EDT, Chris Jaun CLA 		no flags Details | Diff
new patch (2.61 KB, patch)
2011-06-14 17:25 EDT, Chris Jaun CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jaun CLA 2011-06-14 11:46:45 EDT 
JSWebResourceEventManager takes a "dummy" source entry and converts it to the correct source entry after the web module nature has been installed.

However, it is possible that there is an existing library entry that matches the new source path. In this case we do not want to create a conflict, so check if the entry paths match and if they do there is no reason to create the source entry.
Comment 1 Chris Jaun CLA 2011-06-14 11:47:29 EDT 
Created attachment 197962 [details]
patch
Comment 2 Nitin Dahyabhai CLA 2011-06-14 15:25:40 EDT 
Actually, does it matter if one of the resolved entries matching a root path is IIncludePathEntry.CPE_LIBRARY and not some other kind of entry?
Comment 3 Chris Jaun CLA 2011-06-14 17:25:10 EDT 
Created attachment 197984 [details]
new patch

It does not....updated patch.
Comment 4 Chris Jaun CLA 2011-06-15 10:08:32 EDT 
Checked into HEAD and 3.2.5.
Comment 5 Chris Jaun CLA 2011-06-20 11:11:56 EDT 
Minor update made to for loop to change <= to <.