Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349337 - [API] CCE generating metamodel classes
Summary: [API] CCE generating metamodel classes
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.0.1   Edit
Assignee: Karen Butzke CLA
QA Contact:
URL:
Whiteboard: fix_ready
Keywords: api
Depends on:
Blocks:
 
Reported: 2011-06-14 11:32 EDT by Karen Butzke CLA
Modified: 2011-08-04 14:05 EDT (History)
2 users (show)

See Also:
neil.hauge: review+

Attachments
stack trace (2.37 KB, text/plain)
2011-06-14 11:40 EDT, Karen Butzke CLA 		no flags Details
proposed patch against head (5.07 KB, patch)
2011-06-14 13:01 EDT, Karen Butzke CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2011-06-14 11:32:05 EDT 
1. Create a Generic 2.0 JPA project with an orm.xml file
2. Set a canonical metamodel source folder on the JPA properties page.
3. Add this JPA entity:
@Entity
public class Bar {

	@Id
	private int id;
}
4. Add the Bar entity to the orm.xml file. The attached CCE appears in the error log.

java.lang.ClassCastException: org.eclipse.jpt.jpa.core.internal.context.orm.VirtualOrmPersistentAttribute cannot be cast to org.eclipse.jpt.jpa.core.context.PersistentAttribute
	at org.eclipse.jpt.jpa.core.internal.jpa2.GenericMetamodelSynchronizer.printAttributesOn(GenericMetamodelSynchronizer.java:345)
Comment 1 Karen Butzke CLA 2011-06-14 11:40:07 EDT 
Created attachment 197960 [details]
stack trace
Comment 2 Karen Butzke CLA 2011-06-14 13:01:14 EDT 
Created attachment 197965 [details]
proposed patch against head

This patch includes a minor API change: MetamodelSourceType.attributes() generic type had to be changed to ReadOnlyPersistentAttribute from PersistentAttribute. I think this change is warranted because this bug breaks metamodel generation in the orm.xml case if any attribute is not specified in the orm.xml file.
Comment 3 Karen Butzke CLA 2011-06-24 08:07:09 EDT 
checked in to HEAD for 3.0.1
Comment 4 Jolene Moffitt CLA 2011-08-04 14:05:58 EDT 
Verified in Build I-3.4.0-20110731180834

Verified you add an entity to orm.xml if the canonical metamodel source folder is already set.  See the link to view test steps for verification. http://wiki.eclipse.org/Dali_3.0.1