Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349330 - unnecessary 'duplicate generator' validation when name is ""
Summary: unnecessary 'duplicate generator' validation when name is ""
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: JPA (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.1 M1   Edit
Assignee: Nan Li CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-14 10:54 EDT by Karen Butzke CLA
Modified: 2011-11-01 18:25 EDT (History)
2 users (show)

See Also:
neil.hauge: review+


Attachments
Proposed Patch (2.28 KB, patch)
2011-06-15 16:01 EDT, Nan Li CLA
neil.hauge: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2011-06-14 10:54:06 EDT
Create an EclipseLink JPA project and add this entity. Notice there are 6 validation errors. 2 for the converters being unnamed, 2 for the generators being unnamed and 2 for duplicate generators. We do not need the duplicate generators error if the name is "". This should work the same way converters do. The same issues exists for queries.

@Entity
@TableGenerator(name="")
@SequenceGenerator(name="")
@Converter(name="", converterClass=MyConverter.class)
@TypeConverter(name="")
public class Foo {

	@Id
	private int id;
  
}
Comment 1 Nan Li CLA 2011-06-15 16:01:16 EDT
Created attachment 198049 [details]
Proposed Patch
Comment 2 Neil Hauge CLA 2011-07-01 16:25:33 EDT
Moving JPA specific bugs to new JPA component in bugzilla.
Comment 3 Neil Hauge CLA 2011-07-05 17:07:33 EDT
Patch applied to head.
Comment 4 Jolene Moffitt CLA 2011-08-31 12:07:59 EDT
Verified in Build I-3.4.0-20110826171354 

Verified the 2 Duplicate Generator errors do not appear in the problems pane.  See the link to view test steps for verification. 
http://wiki.eclipse.org/Dali_3.1_M1