Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349317 - [Unit Test Failure] Bug345730Test.bug345730Test
Summary: [Unit Test Failure] Bug345730Test.bug345730Test
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-14 09:57 EDT by Gregoire Dupe CLA
Modified: 2020-05-01 11:26 EDT (History)
1 user (show)

See Also:
gdupe: juno+

Attachments
Patch for Bug 349317 (3.13 KB, patch)
2011-06-14 10:12 EDT, Nicolas Guyomar CLA 		gdupe: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregoire Dupe CLA 2011-06-14 09:57:52 EDT 
The unit test Bug345730Test.bug345730Test fails on the build server.

Testcase: bug345730Test took 0.983 sec
	Caused an ERROR

java.lang.AssertionError: 
	at org.eclipse.emf.facet.widgets.nattable.tests.swtbot.Bug345730Test.bug345730Test(Bug345730Test.java:208)
	at org.eclipse.swtbot.eclipse.junit4.headless.EclipseTestRunner.run(EclipseTestRunner.java:350)
	at org.eclipse.swtbot.eclipse.junit4.headless.EclipseTestRunner.run(EclipseTestRunner.java:208)
	at org.eclipse.swtbot.eclipse.junit4.headless.UITestApplication.runTests(UITestApplication.java:116)
	at org.eclipse.ui.internal.testing.WorkbenchTestable$1.run(WorkbenchTestable.java:71)
	at java.lang.Thread.run(Thread.java:595)

Build timed out. Aborting
Comment 1 Nicolas Guyomar CLA 2011-06-14 10:12:45 EDT 
Created attachment 197953 [details]
Patch for Bug 349317

Hi,

Please find attached a fix on the non regression test for Bug 345730.
The EMF Facet Table dirty mode behavior has been modified in Bug 344921.

Expected behavior is that when opened from a model editor, the EMF Facet Table Editor should be dirty, but the model editor should not.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar
Comment 2 Gregoire Dupe CLA 2011-06-14 11:09:33 EDT 
Comment on attachment 197953 [details]
Patch for Bug 349317

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 722.
Comment 3 Gregoire Dupe CLA 2011-06-14 11:09:54 EDT 
This bug can be marked as fixed.
Comment 4 Gregoire Dupe CLA 2011-12-26 07:43:35 EST 
Can be closed.