Community
Participate
Working Groups
Let's look at the git status page. There is "Recent commits on >origin/master< >Fetch< >Merge<" over the second git-log. >origin/master< is a real link and >Fetch< >Merge< just trigger some action. In the object menu we show Href commands in blue and others in black. Shouldn't we have similar distinction for commands in the rest of UI? Otherwise people may be surprised that clicking on >Fetch< starts a real operation instated of taking them to a page where they can perform a push operation.
Created attachment 197945 [details] Href commands and other commands on Git Status page
I agree. I see two options: 1. Use a regular push button, consistent with the "Commit" button that is already on the page. 2. Put the action into the dark background toolbar, similar to other pages. I don't have a strong opinion, option 1 would probably the one with the least amount of code changes.
(In reply to comment #2) > I agree. I see two options: > > 1. Use a regular push button, consistent with the "Commit" button that is > already on the page. > 2. Put the action into the dark background toolbar, similar to other pages. > > I don't have a strong opinion, option 1 would probably the one with the least > amount of code changes. +1. From a command framework point of view, the href commands always appear in the expected command places (dark toolbar, actions column) so there's no doubt. Once we start placing commands in the UI in other places, especially mixed with links, we need something more. Which one is less code depends on whether these are currently being placed by the command framework or directly by the page. Libing can decide (ping me if there is some framework issue here)...
Talked to Libing. The most expedient thing to do here is change the commands to images rather than links, then they stand out as more button-like and have the same behavior as the images in the action column. We will also add command.tooltip tooltips so that we can use more task-oriented words.
reviewed with Libing and ran it remotely. (Cool.) +1
fixed with 8bead786054c8dc722c596a7a0abfae2df2716ef.
