Description Raksha Vasisht 2011-06-14 03:24:24 EDT

BETA_JAVA7

List<Integer> m() {    	
    	HashMap<String, ArrayList<Integer>> field= new HashMap<>();
    	field.put("hi", new ArrayList<Integer>());
    	return  (ArrayList<Integer>)field.get(0);		
}

ctrl+ 1 on field -> Inline Local Variable shown on field declaration, which is wrong and gives a wrong result.

Also in this case:

List<Integer> m() {    	
    	HashMap<String, ArrayList<Integer>> field= new HashMap<>();
    	return null;
}

If the local variable is marked unused, ILV is offered as a quick fix and the declaration is removed. Doing this in the refactoring is ok if explicitly invoked, but should not be offered as a quick fix here.

Also seen earlier to 1.5,

List m() {
    	List list= new ArrayList();
    	list.add(0);
    	return list;
}

We should check code at:

org.eclipse.jdt.internal.corext.refactoring.code.InlineTempRefactoring.checkAssignments(VariableDeclaration)