Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349220 - NPE when trying to Run external Ant script (run as Ant or Ant...)
Summary: NPE when trying to Run external Ant script (run as Ant or Ant...)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.8 M1   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-13 14:43 EDT by trish CLA
Modified: 2011-07-07 15:17 EDT (History)
1 user (show)

See Also:

Attachments
code snippet and full stack trace supporting bug 349220 (4.38 KB, text/plain)
2011-06-13 14:47 EDT, trish CLA 		no flags Details
fix (2.51 KB, patch)
2011-07-07 15:12 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description trish CLA 2011-06-13 14:43:11 EDT 
Build Identifier: 20110218-0911

NPE in AntUtil class, but problem is really inAntLaunchShortcut, getAdapter doesn't return a file for external files, and a null file condition isnt handled in the code.
short stacktrace here, full will be attached

java.lang.NullPointerException
at org.eclipse.ant.internal.ui.AntUtil.isKnownAntFile(AntUtil.java:593)
at org.eclipse.ant.internal.ui.launchConfigurations.AntLaunchShortcut.launch(AntLaunchShortcut.java:465)
at org.eclipse.debug.internal.ui.launchConfigurations.LaunchShortcutExtension.launch(LaunchShortcutExtension.java:424)


Reproducible: Always

Steps to Reproduce:
1.file>open file, select an external ant script
2.Run>external tools>run as
3.chose either Ant or Ant...
nothing appears to be happening, check the error log and you can see the NPE
Comment 1 trish CLA 2011-06-13 14:47:43 EDT 
Created attachment 197916 [details]
code snippet and full stack trace supporting bug 349220

code snippet and stack trace
Comment 2 Michael Rennie CLA 2011-07-07 15:12:51 EDT 
Created attachment 199287 [details]
fix

when we are launching we also need to handle the case the there is no IFile handle and that there could be a file path (leading to a java.io.File handle). In this case we need to have a similar method to ask "is this a known buildfile name?".

The patch adds support for external files.
Comment 3 Michael Rennie CLA 2011-07-07 15:17:42 EDT 
applied patch to HEAD