Community
Participate
Working Groups
Need to make sure the Metatype impl conforms to the outcome of the following resolved CPEG bugs or dispute the resolutions. https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1843 https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1979 https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1974 https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1975 I'm pretty sure it does, but want to be sure the resolutions are reviewed.
If I recall correctly, the current impl will simply return null for an image icon if the specified size does not match exactly. We will probably need an algorithm for determining the icon with the closest matching size and return that instead of null.
(In reply to comment #0) > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1843 > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1979 > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1974 > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1975 https://www.osgi.org/members/bugzilla/show_bug.cgi?id=2182 https://www.osgi.org/members/bugzilla/show_bug.cgi?id=2196
Pushed changes to master based on https://www.osgi.org/members/bugzilla/show_bug.cgi?id=2182 http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=82fc12f75e778e1832afcd9eab8fb561269fca76 http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=e76b83ae31eb5092188f16117981690f0d4872d6
(In reply to comment #2) > > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1843 > > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1979 > > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1974 > > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=1975 > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=2182 > https://www.osgi.org/members/bugzilla/show_bug.cgi?id=2196 Everything looks okay except for 1975. Support for multiple icons in the schema needs to be added as well as an algorithm for finding an icon whose size matches as closely as possible the requested size.
Pushed to master. http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=19d60e3a282f099c5fc666a317cefb9e009bdbfe http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=fbfeed13879f785ab025ec4c82ec3be41c2b9e86 http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=f155652bfb1a057a88b6387b3ee2259a2d412a4c Metatype now supports multiple icon elements within the XML. The icon that is closest to the requested size will be returned.
