Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349186 - R4E Formal review with Decision time spent empty generate error
Summary: R4E Formal review with Decision time spent empty generate error
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 0.9   Edit
Assignee: Sebastien Dubois CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 349183
Blocks:
  Show dependency tree
 
Reported: 2011-06-13 08:50 EDT by Jacques Bouthillier CLA
Modified: 2012-01-24 15:35 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacques Bouthillier CLA 2011-06-13 08:50:01 EDT 
When in a FORMAL review, adjust the "Exit Decision" in DECISION phase, then remove the Decision time spent. If I moved away from the field, the following error is generated:


!ENTRY org.eclipse.ui 4 0 2011-06-13 08:36:15.922

!MESSAGE Unhandled event loop exception

!STACK 0

java.lang.NumberFormatException: For input string: ""

at java.lang.NumberFormatException.forInputString(Unknown Source)

at java.lang.Integer.parseInt(Unknown Source)

at java.lang.Integer.valueOf(Unknown Source)

at org.eclipse.mylyn.reviews.r4e.ui.internal.properties.tabbed.ReviewExtraTabPropertySection$9.focusLost(ReviewExtraTabPropertySection.java:558)

at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:143)

at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)

at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
Comment 1 Sebastien Dubois CLA 2011-06-13 11:06:53 EDT 
THis is fixed by handling the NumberFormatException, which will set the Decison Time Spent to 0 if it occurs
Comment 2 Jacques Bouthillier CLA 2011-06-14 08:40:28 EDT 
After re-testing , I got the following error. We have to consider the user can remove the data in the time field. When he does, the error is generated.

!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NumberFormatException: For input string: ""
	at java.lang.NumberFormatException.forInputString(Unknown Source)
	at java.lang.Integer.parseInt(Unknown Source)
	at java.lang.Integer.valueOf(Unknown Source)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.properties.tabbed.ReviewExtraTabPropertySection$9.focusLost(ReviewExtraTabPropertySection.java:558)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:143)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
Comment 3 Sebastien Dubois CLA 2011-06-14 11:17:47 EDT 
User was using the wrong version.  The problem is fixed