Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349171 - ECF Generic TCP server should not use 'localhost' as name
Summary: ECF Generic TCP server should not use 'localhost' as name
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.server (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: ecf.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-13 06:07 EDT by Alex Blewitt CLA
Modified: 2014-02-12 16:18 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2011-06-13 06:07:12 EDT
The ECF Generic TCP container uses 'localhost' as the identity. This works provided that the machine is indeed localhost, but as soon as you go over a remote system, it doesn't match up. (The Zookeeper advertiser code actually randomly translates 'localhost' to the host name in the strings.)

Instead, the generic TCP server should use either the IP address or the (fully qualified) host name in order to advertise services, even locally, so that if those services are remotely advertised containers don't need to resort to string manipulation in order to run.
Comment 1 Alex Blewitt CLA 2011-06-13 07:10:42 EDT
Hmm. I think this is already working in my experiments with 3.5.1. Perhaps it's just the use of 'localhost' on the command line arguments in the example demos which is confusing me. This might be invalid, e.g. see TCPServerSOContainer.java which looks like it's overriding the default host appropriately.
Comment 2 Alex Blewitt CLA 2011-06-13 08:04:57 EDT
Maybe this bug should be changed to 'Support dynamic port numbers and update examples to use non-localhost and non-default ports' and priority lowered?
Comment 3 Scott Lewis CLA 2014-02-12 16:18:41 EST
(In reply to Alex Blewitt from comment #2)
> Maybe this bug should be changed to 'Support dynamic port numbers and update
> examples to use non-localhost and non-default ports' and priority lowered?

This functionality is now available with the generic provider...via generic-provider-specific service properties.   See under Remote Service Configuration Properties under:

http://wiki.eclipse.org/EIG:Configuration_Properties#ECF_generic_provider