Community
Participate
Working Groups
While running the scenario for bug 349118: 1. Split the shared area vertically into two stacks with the 'Outline' view with the 'Outline' view on the top. You will now have the stack on top and an empty stack on the bottom. 2. Open an editor, it will appear in the same stack as the 'Outline' view (the top stack). Clearly this is undesirable behavior since we now obscure the Outline view with the editor. It would be better if the empty stack were used, we need to do something deeper than just chosing the first visible stack as we now do.
Created attachment 197854 [details] Patch that tries to keep editors away from views This patch uses a 3 stage approach to choosing a stack for an editor. 1) a visible empty stack (as in the scenario) 2) a stack that doesn't contain any Views (MPlaceholders) 3) any visible stack (current behavior) Note that further refinements are possible such as trying not to put two instances of the same editor into the same stack...perhaps even to the extent of creating a new stack if necessary in the New Editor handling (a request from the e4 BOF at eclipsecon).
Created attachment 201341 [details] New patch with same refinements as in comment 1
Remy, could you review this one as well ?
There is a discrepancy in the end result of the two set of steps below. 1. Open a file. 2. Drag a view into the shared area and split it. 3. Close the editor. 4. Close the view. 5. Open a file. 6. Reopen the closed view from step 4. 7. The view is stacked with the editor from step 5. 3. Close the view. 4. Close the editor. 5. Open a file. 6. Reopen the closed view from step 3. 7. The view is opened in its own stack instead of being in the editor's stack.
Hmm, the difference is ultimately determined by the TBR state of the stack containing the view: When you close the editor first its stack goes away, leaving only the stack with the view placeholder in it. Closing the view sets the PH TBR to false but leaves the stack TBR true since it's the only one. In the second scenario we close the view first it sets *both* the TBR for the view and the TBR for the stack to false. Then closing the editor leaves that stack's TBR true since it's the last visible stack (so in this case the EA still has an MPSC with two stacks, one TBR true one false). After a talk with Remy it appears that there are two competing scenarios involving views in the Shared area: 1) Just need more space. This is like moving the Console view into the shared area just to give it the most room to show its info. Here is doesn't really matter whether an editor shares its stack. 2) Want the view to be visible even when the shared area is maximized. This is like dragging the Outline view into the shared area and you specifically do not want editors to go into the same stack.
Eric, should this still be considered for 4.1.2? PW
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
