Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 349106 - [client][git] mini logs don't contain information when not on master
Summary: [client][git] mini logs don't contain information when not on master
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 347323
Blocks:
  Show dependency tree
 
Reported: 2011-06-10 23:23 EDT by Boris Bokowski CLA
Modified: 2011-09-01 11:42 EDT (History)
3 users (show)

See Also:
tomasz.zarna: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Bokowski CLA 2011-06-10 23:23:10 EDT 
Here's what I did: I had master checked out, then I created a new branch and checked out that branch (all using Orion, on the Repositories page). Then, after refreshing the git status page, the mini logs were visible, but empty.
Comment 1 Boris Bokowski CLA 2011-06-10 23:24:50 EDT 
The following is in my console: 

Failed to load resource: the server responded with a status of 405 (HTTP method GET is not supported by this URL)
xhr.js:609Error: Unable to load /gitapi/remote/origin/201106-debugger/file/x/?page=1 status:405
git-status-table.js:585HTTP status code:  405
Comment 2 libing wang CLA 2011-06-15 16:28:27 EDT 
I believe the root cause might be the same as I mentioned in bug 349313 comment 2.
this "/remote/origin/201106-debugger/" branch does not appear in your repo page yet until you do some thing further(e.g. push a change).
Comment 3 libing wang CLA 2011-06-15 16:57:54 EDT 
Gosia , I confirmed the error is the same as what happended in bug 349313.
Please make one of them duplicated the other if you think so.
Comment 4 Malgorzata Janczarska CLA 2011-06-16 07:09:10 EDT 
The problem is that the new local branch doesn't have a remote branch. In this case I think we should display the mini log for local branch and the remote should remain empty with information "no remote branch".
Comment 5 Malgorzata Janczarska CLA 2011-06-17 04:32:58 EDT 
Now we are displaying the message that remote branch doesn't exist. In this case it's all we can do.
Comment 6 Malgorzata Janczarska CLA 2011-06-17 04:47:50 EDT 
This fix was almost good. We should handle 403 and 401 differently.
Comment 7 Malgorzata Janczarska CLA 2011-06-17 05:32:18 EDT 
(In reply to comment #6)
> This fix was almost good. We should handle 403 and 401 differently.
corrected
Comment 8 Malgorzata Janczarska CLA 2011-06-17 12:17:14 EDT 
some more corrections needed
Comment 9 Malgorzata Janczarska CLA 2011-06-17 12:21:59 EDT 
(In reply to comment #8)
> some more corrections needed
There was still a problem when response wasn't a JSON. I corrected it in the same way errors on navigator are displayed.