Community
Participate
Working Groups
The dialog to collect SSH creds required by git clone operation should ask for for password OR key (and passphrase when needed), not both. The user may be confused when he is asked for providing password and the key at the same time.
and please remember the password as long as my session is good...
We are blocked by bug 349034 which is blocked by a JSch issue. Tomek was asked to find out when JSch guys are fixing it, but most likely it is not by Orion 0.3. What we can do here is: - tweak the dialog a bit, so it is clear that either the password OR the key (and passphrase) is needed - store the credentials in the session storage so JJ (and others) can work with Orion without that annoying credential dialog showing up again and again
(In reply to comment #2) > What we can do here is: > - tweak the dialog a bit, so it is clear that either the password OR the key > (and passphrase) is needed done > - store the credentials in the session storage so JJ (and others) can work with > Orion without that annoying credential dialog showing up again and again But do we really want to store credentials? There were ideas like this before and then we were against storing credentials. Generally I don't know a good way to store credentials from javascript level without requiring any browser plugins, because all would require a symmetrical encryption of passwords. The safest thing I can think of is to store passwords in session storage that is cleared whenever the browser window is closed, but it doesn't solve the problem completely, because JJB wouldn't like to re-enter his password on every new Orion window.
(In reply to comment #3) > But do we really want to store credentials? There were ideas like this before > and then we were against storing credentials. These were discussions about storing credentials on the server side. > The safest thing I can think of is to store passwords in session storage that is > cleared whenever the browser window is closed, but it doesn't solve the problem > completely, because JJB wouldn't like to re-enter his password on every new > Orion window. Right. We were already chatting about using the session storage, that's why I wrote "store the credentials in the session storage". I would raise a separate bug for remembering credentials, unless there is one already. We could use it for further investigation. BTW the issue from the summary i.e. "Clone Git Repository should ask for password OR key+passphrase, not both" is actually fixed. If JJ agrees we can close this bug and raise another one for consuming changes described in bug 349034.
Created attachment 204537 [details] Oct 3 git push ui
The new pop up is an improvement. I think it would be even better with a small change: Add a blank line between the two areas. That will make the brain fuse the rows of the table as units rather than the columns. Currently the rows of text entry touch, making the user think they form a unit. Borders around the rows would also work, but a blank is good enough.
I rised another bug for saving credentials: Bug 359952.
We are still blocked with no clear views for the future, so I'm taking off the target. I'll set it when we have any clear declaration from JSCh.
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg04002.html
