Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348982 - [api] misuse of the generics in OperationsFactory
Summary: [api] misuse of the generics in OperationsFactory
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.7.1   Edit
Assignee: Pascal Rapicault CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-09 20:05 EDT by Pascal Rapicault CLA
Modified: 2011-06-10 21:37 EDT (History)
0 users

See Also:

Attachments
Very simple patch that just changes the signatures. This change is backward compatible with the previous version. (3.21 KB, patch)
2011-06-10 08:38 EDT, Hugo Corbucci CLA 		pascal: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2011-06-09 20:05:10 EDT 
In the operationsFactory class, most of the methods take a Collection<IVersionedId> but this is not sufficient to have it take a Collection<IInstallableUnit> as input.
Instead the signatures should be Collection<? extends IVersionedId>.
Comment 1 Hugo Corbucci CLA 2011-06-10 08:38:42 EDT 
Created attachment 197768 [details]
Very simple patch that just changes the signatures. This change is backward compatible with the previous version.

Very simples patch that just changes the signatures in all methods. As the change is backward compatible, it should not cause any issue with tests or previously implemented code.
Also, be careful as to update the javadocs if the results of bug 348981 get applied before this patch.
Comment 2 Pascal Rapicault CLA 2011-06-10 21:35:14 EDT 
Comment on attachment 197768 [details]
Very simple patch that just changes the signatures. This change is backward compatible with the previous version.

Thx for the patch. Fix in HEAD and in 3.7.1
Comment 3 Pascal Rapicault CLA 2011-06-10 21:37:45 EDT 
closing