Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348926 - Problems with ChangeDescription#copyAndReverse(...)
Summary: Problems with ChangeDescription#copyAndReverse(...)
Status: VERIFIED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Core (show other bugs)
Version: 2.7.0   Edit
Hardware: PC Linux Qt
: P3 normal (vote)
Target Milestone: SR1   Edit
Assignee: Ed Merks CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-09 12:19 EDT by Kenn Hussey CLA
Modified: 2011-08-31 22:20 EDT (History)
0 users

See Also:
Kenn.Hussey: indigo+

Attachments
updated test case (2.54 KB, patch)
2011-06-09 12:25 EDT, Kenn Hussey CLA 		no flags Details | Diff
Patches to address several issues. (3.04 KB, patch)
2011-08-29 13:24 EDT, Ed Merks CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenn Hussey CLA 2011-06-09 12:19:13 EDT 
The following problems exist with this method, as demonstrated by a test case which I will attach shortly:

- nested child objects in separate resources don't get added when applying the changes
- references to nested child objects get added twice when applying the changes
Comment 1 Kenn Hussey CLA 2011-06-09 12:25:17 EDT 
Created attachment 197704 [details]
updated test case

Here's an updated version of the existing test case which adds a new test demonstrating the problems.
Comment 2 Ed Merks CLA 2011-08-29 13:24:16 EDT 
Created attachment 202346 [details]
Patches to address several issues.

These are three changes to address all the problems related to the change recorder that you reported.
Comment 3 Kenn Hussey CLA 2011-08-29 18:12:08 EDT 
The fixes have been committed to CVS (head and maintenance).
Comment 4 Kenn Hussey CLA 2011-08-29 19:51:01 EDT 
The fixes are available in maintenance build M201108291525 and integration build I201108291838.