Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348914 - [Usability] Two click Edge creation - click to select source - click to select target
Summary: [Usability] Two click Edge creation - click to select source - click to selec...
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 0.8.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-09 11:10 EDT by Yann Tanguy CLA
Modified: 2011-06-09 11:10 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yann Tanguy CLA 2011-06-09 11:10:23 EDT
Two click Edge creation - click to select source - click to select target.


It’s a permanent enhancement, the change was made in r4587 (org.eclipse.papyrus.diagram.common.service.AspectUnspecifiedTypeConnectionTool::handleButtonUp() method)

       /**
       * @see org.eclipse.gef.tools.AbstractTool#handleButtonUp(int)
       */
       protected boolean handleButtonUp(int button) {
             setCtrlKeyDown(getCurrentInput().isControlKeyDown());

             if(isInState(STATE_CONNECTION_STARTED)) {
                    setState(STATE_CONNECTION_WAITING_END);
                    return false;
             } else if(isInState(STATE_CONNECTION_WAITING_END)) {
                    handleCreateConnection();
             }

             setState(STATE_TERMINAL);

             if(isInState(STATE_TERMINAL | STATE_INVALID)) {
                    handleFinished();
             }

             return true;
       }

instead of 

       /**
       * @see org.eclipse.gef.tools.AbstractTool#handleButtonUp(int)
       */
       protected boolean handleButtonUp(int button) {
             setCtrlKeyDown(getCurrentInput().isControlKeyDown());

             if (isInState(STATE_CONNECTION_STARTED))
                    handleCreateConnection();
             setState(STATE_TERMINAL);

             if (isInState(STATE_TERMINAL | STATE_INVALID)) {
                    handleFinished();
             }

             return true;
       }

Regards,

Yann

De : mdt-papyrus.dev-bounces@eclipse.org [mailto:mdt-papyrus.dev-bounces@eclipse.org] De la part de 
Objet : [mdt-papyrus.dev] Edge creation

Hi,
            I am currently working on Papyrus and I have just discovered that the edge creation method has changed. Before the edge has to be dragged from one point to another whereas now you have to click on the starting point and on the ending to create it. I would like to know if it’s a permanent enhancement or if it’s just temporary. In fact, it impacts a framework I’m working on. Can someone please confirm that it’s permanent?
Comment 1 Yann Tanguy CLA 2011-06-09 11:10:50 EDT
Was added in r4587.