Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348866 - [SysML Block Definition Diagram] Part, Ref creation incorrectly allowed on Block header after inherited element creation
Summary: [SysML Block Definition Diagram] Part, Ref creation incorrectly allowed on Bl...
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: SR1   Edit
Assignee: Yann Tanguy CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 346739
Blocks:
  Show dependency tree
 
Reported: 2011-06-09 07:09 EDT by Yann Tanguy CLA
Modified: 2011-07-27 04:28 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yann Tanguy CLA 2011-06-09 07:09:54 EDT 
The creation of inherited element (ex: Package, InstanceSpecification...) triggers the related ViewProvider loading.
Once loaded the class provides(ViewForKind) methods always returns true (only the diagram type is checked) even in case
the provider is not able to create a view.

The ViewProvider implementation has to be fixed, but the CreateEditPolicy should also make sure a non-null view can be created before returning the view creation command.
Comment 1 Yann Tanguy CLA 2011-07-07 16:57:17 EDT 
In r5004:
- EditPolicy fixes (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=346739)
- Palette factory now directly rely on IElementTypes from service edit (except for CommentAnnotated and ConstraintConstrained links)
- plugin.xml provider loading condition modified accordingly to previous change
- BDD view provider implementation corrected
Comment 2 Yann Tanguy CLA 2011-07-27 04:28:12 EDT 
Merge in trunk : r5130.