Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 348839 - wrong p2.mirrorsURL
Summary: wrong p2.mirrorsURL
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Main (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: 0.10.0 M1   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-09 04:03 EDT by Nicolas Bros CLA
Modified: 2013-04-26 09:23 EDT (History)
3 users (show)

See Also:
gdupe: juno+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-06-09 04:03:00 EDT 
From a recent discussion on cross-project-issues-dev, I noticed that the p2.mirrorsURL in the MoDisco update site metadata is wrong.
It is currently:
<property name='p2.mirrorsURL' value='http://www.eclipse.org/modeling/updates/'/>
I think it should be:
<property name='p2.mirrorsURL' value='http://www.eclipse.org/downloads/download.php?file=/modeling/mdt/modisco/updates/release/0.9.0/&amp;format=xml&amp;protocol=http'/>
Comment 1 Nicolas Bros CLA 2011-06-09 04:04:16 EDT 
To fix this, I think this bit of XML should be updated in each feature.xml:
<url>
      <update label="%ModelingUpdateSiteName" url="http://www.eclipse.org/modeling/updates/"/>
</url>
Comment 2 Gregoire Dupe CLA 2011-06-09 11:59:04 EDT 
(In reply to comment #1)
> To fix this, I think this bit of XML should be updated in each feature.xml:
> <url>
>       <update label="%ModelingUpdateSiteName"
> url="http://www.eclipse.org/modeling/updates/"/>
> </url>

-1 because http://www.eclipse.org/downloads/download.php?file=/modeling/mdt/modisco/updates/release/0.8.0/&format=xml&protocol=http is not an update site.
Comment 3 Nicolas Bros CLA 2011-08-10 05:13:50 EDT 
(In reply to comment #2)
> -1 because
> http://www.eclipse.org/downloads/download.php?file=/modeling/mdt/modisco/updates/release/0.8.0/&format=xml&protocol=http
> is not an update site.

It is indeed not an update site, but p2 must be able to understand it anyway, since Eclipse platform specifies it this way.
See for example: http://download.eclipse.org/eclipse/updates/3.6/R-3.6.2-201102101200/artifacts.jar

This is also documented here:
http://wiki.eclipse.org/IT_Infrastructure_Doc#Enable_mirrors_.2F_use_mirrorsURL_for_my_p2_repo.3F
Comment 4 Nicolas Bros CLA 2011-08-10 08:44:26 EDT 
I added the generation of the "p2.mirrorsURL" properties in the XSLT transformation that is run during the promote.
I also removed the discovery & update site definitions from all feature.xml to avoid generating wrong "p2.mirrorsURL"s (resulting in duplicated properties in the metadata).
Comment 5 Hugo Bruneliere CLA 2011-08-18 08:33:24 EDT 
Bug solved.